Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove option to allow any top level parameter #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaywcarman
Copy link
Collaborator

Some modules do not support any top level parameters, which is also
represented as an empty list (causing unsupported arguments like
'ibmcloud_api_key' to be templated into the Terraform block). There
aren't any modules that allow arbitrary parameters so this option is not
even needed.

fixes #61

Some modules do not support _any_ top level parameters, which is also
represented as an empty list (causing unsupported arguments like
'ibmcloud_api_key' to be templated into the Terraform block). There
aren't any modules that allow arbitrary parameters so this option is not
even needed.
@treytabner
Copy link

treytabner commented Jun 11, 2021

I'm testing with this PR and it does fix the problem with ibm_is_images_info but I think it breaks a list of dicts for example https://github.com/IBM-Cloud/ansible-collection-ibm/blob/master/examples/simple-vm-ssh/create.yml#L70-L71, this renders primary_network_interface with no subnet:

resource ibm_is_instance "ansibletestvsi" {
  name = "ansible-test-vsi"
  vpc = "r006-20df8e8d-4ef4-4311-8122-7929db1232c8"
  profile = "bx2-2x8"
  image = "r006-988caa8b-7786-49c9-aea6-9553af2b1969"
  keys = ["r006-75132256-1f0e-437b-b973-366bdd2d02a5"]
  primary_network_interface {
    }
  zone = "us-south-3"
}

Edit: it's also dropping port_min and port_max here for example: https://github.com/IBM-Cloud/ansible-collection-ibm/blob/master/examples/simple-vm-ssh/create.yml#L104-L105

@kavya498
Copy link
Contributor

@jaywcarman , can you please attach test results for this?

@jaywcarman
Copy link
Collaborator Author

@kavya498 I'll need to make updates before this can be merged, but am not sure when I'll have time. Moving this to a WIP for now.

@jaywcarman jaywcarman changed the title Remove option to allow any top level parameter [WIP] Remove option to allow any top level parameter Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to retrive the image.
3 participants