V1.66.0 with fixes #127
Open
V1.66.0 with fixes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the default 'validate_tl_params' value to 'None' causes issues later since 'len(None)' raises TypeError.
The indentation in the terraform resource block generator was inconsistent and very confusing. kwarg default values are assigned elsewhere without spaces.
Only one is necessary
Some modules have conditional parameter requirements (for example, if one paramter is not provided then another may be required). This can result in a module where no parameter is unconditional required (read: "0" required parameters), yet it is required that a parameter be provided.
jaywcarman
force-pushed
the
v1.66.0_with_fixes
branch
from
01d3af2 to
bc20d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @sean-freeman and @hkantare