Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include info on using github repo as gem source. #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update README to include info on using github repo as gem source. #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8f976d
Update README.md
gbrl Oct 28, 2016
e3ebf7d
Merge pull request #1 from gbrl/gbrl-patch-1
gbrl Oct 28, 2016
e749062
Trying to get the gem to call send_two_factor_authentication_code method
gbrl Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@

### Initial Setup

In a Rails environment, require the gem in your Gemfile:
For Rails 5+ require the gem file and point the src to this github repo:

gem 'two_factor_authentication', github: "Houdini/two_factor_authentication"

In other Rails environments, require the gem in your Gemfile:

gem 'two_factor_authentication'

Expand Down
2 changes: 1 addition & 1 deletion lib/two_factor_authentication/hooks/two_factor_authenticatable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

if user.respond_to?(:need_two_factor_authentication?) && !bypass_by_cookie
if auth.session(options[:scope])[TwoFactorAuthentication::NEED_AUTHENTICATION] = user.need_two_factor_authentication?(auth.request)
user.send_new_otp unless user.totp_enabled?
user.send_new_otp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this changed? What about Google Authenticator users?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, misunderstanding. All good 👍

end
end
end