Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ const enforcing #221

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

C++ const enforcing #221

wants to merge 21 commits into from

Conversation

AeroStun
Copy link

Night session of const enforcing and changing C includes to C++ ones

AeroStun added 21 commits January 14, 2018 00:08
@AeroStun
Proper C++ standard header name
c826223 
Changing the C <ABC.h> format to the C++ <cABC>
@AeroStun
C style to C++ style
e841865 
changing typedefs to usings for increased readability
@AeroStun
Removed human redundancy
2f4221f 
Error prone code let to one input
@AeroStun
Merge pull request #1 from AeroStun/patch-1
13982d8 
Proper C++ standard header name
@AeroStun
Merge pull request #2 from AeroStun/patch-2
4d28223 
C style to C++ style
@AeroStun
Merge pull request #3 from AeroStun/patch-3
1ba9226 
Removed human redundancy
@AeroStun
C to C++ headers
8e949f1
@AeroStun
Const correctness applied
c4a3bc2 
Put const wherever it can be useful without touching the function signatures
Also folded T v; v = u; to T v = u;
@AeroStun
C to C++ style
89436bf 
typedefs become usings
for loop now in range mode
@AeroStun
const correctness
11c1599
@AeroStun
Update Tile.cpp
55c732a
@AeroStun
const correctness
3d1d23c
@AeroStun
const correctness
eb8fb34
@AeroStun
const correctness
2c26487
@AeroStun
for range
929f0d5 
incrementing range-for like pattern
Simpler to write a pure range for
Also, enforced const correctness
@AeroStun
const correctness
3312b64
@AeroStun
const correctness
e4a02f6
@AeroStun
const correctness
411fdb2
@AeroStun
const correctness
b91a45c
@AeroStun
const correctness
5eb0224
@AeroStun
const correctness
6fbafbc
@AeroStun
Copy link
Author

How nice the SFML dependency can't build
I guess the travis misses the X11 Xrandr library

@HumbleDeer
Copy link
Collaborator

HumbleDeer commented Jan 14, 2018 •
edited
Loading

I don't think it's a good idea to still add new dependencies. Is it possible without them? if not, I'll see if I can add them to Travis.
RandR is usually included in xorg-dev or libglu1-mesa-dev

@AeroStun
Copy link
Author

It's actually not a dependency we added ourselves, it's the last master version of SFML that requires it
Check this line of the travis log to see
Check this other github issue for a fix

@HumbleDeer
Copy link
Collaborator

Hmm. Okay.

@HumbleDeer
Copy link
Collaborator

If it's SFML then it could be possible to include it in our repository so it's not a system requirement but just included in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AeroStun @HumbleDeer