-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Publish Docker images with github action #1863
base: main
Are you sure you want to change the base?
Conversation
好的,这是将审查指南翻译成中文的结果: Sourcery 审查者指南此 Pull Request 引入了一个新的 GitHub Actions 工作流 ( 由于更改看起来很简单,不需要可视化表示,因此未生成图表。 文件级别更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的 仪表板 以:
获得帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request introduces a new GitHub Actions workflow ( No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @zclkkk - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 考虑为以
release
分支为目标的拉取请求添加触发器,以便在合并时自动构建镜像。
以下是我在审查期间查看的内容
- 🟡 一般问题:发现 1 个问题
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我更有用!请点击每个评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @zclkkk - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a trigger for pull requests targeting the
release
branch to automatically build images on merge.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- name: Build and push Docker image | ||
id: push | ||
uses: docker/build-push-action@f2a1d5e99d037542a71f64918e516c093c6f3fc4 | ||
with: | ||
context: . | ||
push: true | ||
tags: ${{ steps.meta.outputs.tags }} | ||
labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using docker/setup-buildx-action@v3
to introduce the caching mechanism with actions/cache@v4
and updating the cache configuration in docker/build-push-action@v6
as per the official Docker documentation. Also, please remember to update the cache, including the "Move cache" step. If it's out of scope for this PR, we could explore it in a follow-up. What do you think?
uses: actions/checkout@v4 | ||
# Uses the `docker/login-action` action to log in to the Container registry registry using the account and password that will publish the packages. Once published, the packages are scoped to the account defined here. | ||
- name: Log in to the Container registry | ||
uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer locking the version to the major release in the action rather than using a SHA like docker/build-push-action@v6
This PR looks great! We really appreciate the effort you've put into it. Looking forward to the update. Thanks! |
press the green button under action to build docker image & push to ghcr easily :)