-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #85
Conversation
This solves the X-en and en-X problem for English-centric parallel data as autoencoder input.
41d1573
to
d32140e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly LGTM, but let's wait for @jrvc's perpsective before merging
|
||
Path templates for validation sets. | ||
The path templates can contain the same variables as `src_path` and `tgt_path`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add example directory structure that would make this work
docs/source/quickstart.md
Outdated
|
||
model_dim: 512 | ||
```bash | ||
python ${MAMMOTH_DIR}/tools/config_config.py \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mammoth bin instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #86
docs/source/quickstart.md
Outdated
|
||
# INPUT/OUTPUT VOCABULARY CONFIG | ||
```bash | ||
python ${MAMMOTH_DIR}/tools/generate_synth_data.py \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this part of standard tools? if yes, why do require git cloning ; if no, can't we just suggesting wgetting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #86
docs/source/quickstart.md
Outdated
(this should only take a few seconds) | ||
|
||
```bash | ||
python ${MAMMOTH_DIR}/tools/config_config.py \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use mammoth tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #86
Three scripts formerly in the tools directory have been promoted to mammoth.bin and made into installable scripts. - mammoth_config_config: Your trusted config swiss army knife. - mammoth_iterate_tasks: Helper for iterating over all tasks in a config. - mammoth_generate_synth_data: Toy data used in quickstart.
2 weeks have passed with no objection. I'll go ahead and merge. |
config_config
tool