Makes PARTITION BY happen only for GP

generalizing 5aaca9ca5e309bd95204488ed99ba63c909cf5ca
HazyResearch · Jan 24, 2017 · 97c6df5 · 97c6df5
1 parent f723895
commit 97c6df5
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 18 deletions.
diff --git a/compiler/compile-config/compile-config-2.01-grounding b/compiler/compile-config/compile-config-2.01-grounding
@@ -386,24 +386,37 @@ def factorWeightDescriptionSqlExpr:
                     ]
                 } | asSql | asPrettySqlArg)
 
-            deepdive create table \(.factorsTable + "_dummy" | @sh) as \(
-                "SELECT * FROM \(.factorsTable + "_view") LIMIT 0" | asPrettySqlArg )
-
-            # TODO(netj): turn this off for PG
-            CREATE_TABLE_EXTRA_CLAUSES=\"
-                PARTITION BY RANGE(pid)
-                ( START (0) INCLUSIVE
-                  END ( \($deepdive.sampler.partitions) ) EXCLUSIVE
-                  EVERY (1) )\" \\
-            deepdive create table \(.factorsTable | @sh) like \(.factorsTable + "_dummy" | @sh)
-
-            deepdive sql \("
-                INSERT INTO \(.factorsTable | asSqlIdent)
-                SELECT * FROM \(.factorsTable + "_view")
-            " | asPrettySqlArg)
-
-            deepdive sql \("DROP TABLE \(.factorsTable)_dummy" | asPrettySqlArg)
-
+            case $(eval \"$(deepdive db parse)\"; echo $DBVARIANT) in
+                greenplum) # specialization for Greenplum with PARTITION BY
+                    deepdive create table \(.factorsTable + "_dummy" | @sh) as \("
+                        SELECT * FROM \(.factorsTable + "_view" | asSqlIdent)
+                        LIMIT 0
+                    " | asPrettySqlArg)
+
+                    CREATE_TABLE_EXTRA_CLAUSES='
+                        PARTITION BY RANGE(pid)
+                        ( START (0) INCLUSIVE
+                          END (\($deepdive.sampler.partitions)) EXCLUSIVE
+                          EVERY (1)
+                        )' \\
+                    deepdive create table \(.factorsTable | @sh) like \(
+                        .factorsTable + "_dummy" | @sh)
+
+                    deepdive sql \("
+                        INSERT INTO \(.factorsTable | asSqlIdent)
+                        SELECT * FROM \(.factorsTable + "_view" | asSqlIdent)
+                    " | asPrettySqlArg)
+
+                    deepdive sql \("
+                        DROP TABLE \(.factorsTable + "_dummy" | asSqlIdent)
+                    " | asPrettySqlArg)
+                    ;;
+
+                *) # otherwise, simply materialize the view
+                    deepdive create table \(.factorsTable | @sh) as \("
+                        SELECT * FROM \(.factorsTable + "_view" | asSqlIdent)
+                    " | asPrettySqlArg)
+            esac
             deepdive db analyze \(.factorsTable | @sh)
 
             # find distinct weights for the factors into a separate table

diff --git a/database/db-driver/postgresql/db-parse b/database/db-driver/postgresql/db-parse
@@ -3,6 +3,8 @@
 # > db-parse "$url"
 set -eu
 
+[[ $# -gt 0 ]] || set -- "$DEEPDIVE_DB_URL"
+
 . parse-url.sh "$@"
 
 # use bundled postgresql if no psql is available