Code smells resolved

HarmlessKey · Nov 3, 2023 · 6f2eab6 · 6f2eab6
1 parent 143d52b
commit 6f2eab6
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 15 deletions.
diff --git a/src/boot/plugins.js b/src/boot/plugins.js
@@ -6,7 +6,6 @@ import "animate.css";
 import Croppa from "vue-croppa";
 import { Cookies } from "quasar";
 import { Splitpanes, Pane } from "splitpanes";
-// import "splitpanes/dist/splitpanes.css";
 
 export default async ({ router, Vue }) => {
 	Vue.config.productionTip = false;

diff --git a/src/components/MusicPlayer.vue b/src/components/MusicPlayer.vue
@@ -6,7 +6,6 @@
 			:src="`${music_url}?autoplay=1&mute=0&playsinline=1&controls=0`"
 			title="Music player"
 			class="music-player"
-			frameborder="0"
 			allow="autoplay"
 		/>
 		<iframe
@@ -15,7 +14,6 @@
 			:src="`${ambience_url(sound.url)}?autoplay=1&mute=0&playsinline=1&controls=0`"
 			title="Music player"
 			class="music-player"
-			frameborder="0"
 			allow="autoplay"
 		/>
 	</div>

diff --git a/src/components/campaign/resources/Notes.vue b/src/components/campaign/resources/Notes.vue
@@ -129,4 +129,3 @@ export default {
 };
 </script>
 
-<style lang="scss" scoped></style>
diff --git a/src/components/drawers/encounter/TargetingInfo.vue b/src/components/drawers/encounter/TargetingInfo.vue
@@ -24,7 +24,3 @@
 		props: ['type', 'data']
 	};
 </script>
-
-<style lang="scss" scoped>
-
-</style>
diff --git a/src/components/encounters/Entities.vue b/src/components/encounters/Entities.vue
@@ -805,9 +805,6 @@ input[type="number"]::-webkit-inner-spin-button {
 		}
 	}
 }
-// .multi_nr::v-deep .q-field__inner {
-// 	display: none;
-// }
 
 .players {
 	display: flex;

diff --git a/src/components/settings/General.vue b/src/components/settings/General.vue
@@ -257,10 +257,9 @@ export default {
 			let options = this.types[type].type_settings.filter((item) => {
 				return item.key === key;
 			})[0].options;
-			const selected = options.filter((item) => {
+			return options.filter((item) => {
 				return item.value === value;
 			})[0];
-			return selected;
 		},
 	},
 };

diff --git a/src/components/trackCampaign/Sharing.vue b/src/components/trackCampaign/Sharing.vue
@@ -6,7 +6,6 @@
 			:src="`${sharing.youtube}?autoplay=1&mute=0&playsinline=1`"
 			title="YouTube video player"
 			class="youtube-player"
-			frameborder="0"
 			allow="autoplay"
 		/>
 		<div v-if="sharing.message" class="message">{{ sharing.message.trim() }}</div>

diff --git a/src/components/weather/index.vue b/src/components/weather/index.vue
@@ -44,7 +44,6 @@
 				:src="`${backgroundYoutube}?autoplay=1&mute=${mute_youtube}&playsinline=1&controls=0`"
 				title="YouTube video player"
 				class="youtube-player"
-				frameborder="0"
 				allow="autoplay"
 			/>
 			<q-resize-observer v-if="backgroundYoutube" @resize="setSize" />
Original file line number	Diff line number	Diff line change
Expand Up		@@ -129,4 +129,3 @@ export default {
		};
		</script>

		<style lang="scss" scoped></style>