Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point Shop Page 2024 #522

Merged
merged 56 commits into from
Feb 4, 2024
Merged

Point Shop Page 2024 #522

merged 56 commits into from
Feb 4, 2024

Conversation

leesunny790
Copy link
Contributor

No description provided.

@leesunny790 leesunny790 changed the title Initial points shop branch Points shop 2024 Dec 3, 2023
@leesunny790 leesunny790 changed the title Points shop 2024 Points Shop 2024 Dec 3, 2023
@leahlud leahlud linked an issue Dec 3, 2023 that may be closed by this pull request
Point Shop 2024 #509
Closed
12 tasks
@leahlud leahlud changed the title Points Shop 2024 Point Shop 2024 Dec 11, 2023
@leahlud leahlud changed the title Point Shop 2024 Point Shop Page 2024 Dec 28, 2023
@leesunny790 leesunny790 force-pushed the sunny/points-shop-2024 branch from 345ca43 to b807fd5 Compare January 10, 2024 02:59
@leesunny790 leesunny790 force-pushed the sunny/points-shop-2024 branch from 1ed9e49 to f6b8873 Compare January 10, 2024 04:02
@leahlud
Copy link
Contributor

leahlud commented Jan 10, 2024 •
edited by leesunny790
Loading

nice progress! just a few notes so far:

  • can you modify the background and page title constraints according to this doc?
  • imageview_points_shop_banner needs to be constrained horizontally in fragment_points_shop.xml
  • small thing: it's "Point Shop" instead of "Points Shop"

@leesunny790 leesunny790 force-pushed the sunny/points-shop-2024 branch from 7491963 to ca7d8dd Compare January 13, 2024 10:43
leahlud
leahlud requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@leahlud leahlud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final things:

  • add click listeners to MERCH and RAFFLE tabs and filter the items being shown by their isRaffle field
  • add the brown divider after the last item in the recycler view

@leesunny790
Copy link
Contributor Author

image divider is shown at bottom when there are less than 4

@leahlud leahlud merged commit 752008b into development Feb 4, 2024
2 checks passed
@leahlud leahlud deleted the sunny/points-shop-2024 branch February 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahlud leahlud leahlud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Point Shop 2024
2 participants
@leesunny790 @leahlud