Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Page 2024 #521

Merged
merged 47 commits into from
Feb 15, 2024
Merged

Schedule Page 2024 #521

merged 47 commits into from
Feb 15, 2024

Conversation

dominick-deseta
Copy link
Contributor

Working on UI Designs, Functionality, and Extras

@dominick-deseta dominick-deseta linked an issue Dec 3, 2023 that may be closed by this pull request
16 tasks
@dominick-deseta dominick-deseta changed the title Schedule Page 2024 #507 Schedule Page 2024 Dec 3, 2023
@leahlud
Copy link
Contributor

leahlud commented Jan 14, 2024

nice work so far! a few notes:

  • I think it would be better if the schedule/shifts labels were farther apart, can you make it so there's a 35dp starting margin for "Schedule" and a 35dp ending margin for "Shifts"? and get rid of the 50dp margin you set programmatically
  • make the time dividers formatted like 5:00 AM
  • guests should not be able to see the bookmarks either

@leahlud
Copy link
Contributor

leahlud commented Jan 15, 2024

Potion tabs look awesome!! Some notes:

  • shifts tab should have the pink bg, and the highlighted potion should be the blue/green color
  • fix the kt lint errors
image

leahlud
leahlud previously requested changes Feb 1, 2024
Copy link
Contributor

@leahlud leahlud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • bug: if you click on an event with a pro tag, the event card doesn't retain the pro tag
  • add isPro field to event entity and display on events
  • look into fragment lifecycles with event card thingy
  • add mapImageUrl field to event entity and display the map in event card expanded view
  • event.sponsor will return empty string if there is no sponsor
  • add padding beneath potions on schedule so when you scroll it doesn't go right up to them
  • refresh animation?

@leahlud
Copy link
Contributor

leahlud commented Feb 14, 2024

issues

  • events are showing up on shifts page (first time opened)
  • if logged in as attendee or guest, DONT fetch shifts

@AdityaK2905 AdityaK2905 self-assigned this Feb 15, 2024
@AdityaK2905 AdityaK2905 removed their assignment Feb 15, 2024
@AdityaK2905 AdityaK2905 self-requested a review February 15, 2024 03:39
@leahlud leahlud self-requested a review February 15, 2024 03:51
Copy link
Contributor

@AdityaK2905 AdityaK2905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING

Copy link
Contributor

@leahlud leahlud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@leahlud leahlud merged commit 4cd63bc into development Feb 15, 2024
2 checks passed
@leahlud leahlud deleted the dominick/schedule-2024 branch February 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule Page 2024
3 participants