Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invenio accounts update #559

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Invenio accounts update #559

merged 6 commits into from
Nov 9, 2022

Conversation

ItIsJordan
Copy link
Collaborator

@ItIsJordan ItIsJordan commented Nov 8, 2022

Updates Flask-Login, invenio-accounts, invenio-app, invenio-oauthclient, invenio-userprofiles to their latest versions and includes required changes.

Run hepdata alembic upgrade to migrate relevant tables of the database to the new Invenio versions. It might be a good idea to first dump the database (pg_dump) so that it can be later restored (pg_restore) if necessary.

Testing hepdata alembic upgrade on a copy of the production database gave a couple of issues (inveniosoftware/invenio-userprofiles#151) that need to be worked around.

Closes #539.
Closes #552.
Closes #553.

Updates invenio-accounts (1.4.13->2.0.0), invenio-app (1.3.1->1.3.4), invenio-oauthclient (1.5.4->2.0.1), invenio-userprofiles(1.2.1->2.0.3) and Flask-login (0.4.1->0.6.2) in requirements.txt
Fixes previous password hashing behaviour that was changed with the invenio-accounts update.
Moves the dashboardTestMockObject variable to be inside the Flask app context.
Replace deprecated UserProfile function filter_by to use get_by_userid.
Adds the new LoginInformation functionality added by invenio-accounts 2.0.0 to test_accounts.
@coveralls
Copy link

coveralls commented Nov 8, 2022

Coverage Status

Coverage remained the same at 82.54% when pulling ac74e0c on invenio-accounts-update into 5f330fb on master.

The dashboardTestMockObjects variable is declared in multiple locations within dashboard_test.py. The get_mock_user_object function now generates and returns this to reduce duplication.
Copy link
Member

@GraemeWatt GraemeWatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I'll merge now.

@GraemeWatt GraemeWatt merged commit 73837be into master Nov 9, 2022
@GraemeWatt GraemeWatt deleted the invenio-accounts-update branch November 9, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants