#245 fix for Newsfeed "complete first task for today"

[Arilas]

Depends on GrooveOtter/grooveotter-api#24 because previous notifications created without task.

[Arilas]

Also, previous Notifications about 'first_task' we cannot like, because it's doesn't related to any task

[garrethdev]

Bug still happening on branch. I updated the server side too, and still no luck. It seems to be the same issue.

[Arilas]

As I said, "like" will work only for new Notifications, old ones doesn't have task, so like will not work for it. We can remove old notifications with type 'notification'

[garrethdev]

Yea this is a new notification. I accessed the heroku postgres instance and deleted all Notifications before I tested this and created a new one.

[Arilas]

Is this instance contains changes from this: GrooveOtter/grooveotter-api#24 ? Because only after this change, it's should work. Can you see table notifications in DB, task_id should be populated in all notifications?

[garrethdev]

@Arilas yea that api branch is already merged into master. You should be able to test this by deleting Notifications, and removing the Cookie TaskDay on the Client side. To access the DB:
1. Run heroku pg:psql --app whispering-scrubland-7949
2. Run DELETE FROM notifications WHERE type = 'notification';

From there you would just need to complete a few tasks to create a notification or just Post to the API as a notification

[Arilas]

I've checked again and it's works on local machine. And also I see that from server side going list with empty task_id column. Can you please update instance? Because as I see, pull request to API side is merged after creation of this instance

[garrethdev]

@Arilas Im not quite clear what besides this needs to be merged into master?
GrooveOtter/grooveotter-api#24

[Arilas]

As I see, Client send 'task_id' to server, but server doesn't save it(You can look at db, new notifications doesn't have this field). This bug was fixed in GrooveOtter/grooveotter-api#24 that was successfully merged. But as I see, it's was merged after this heroku inastance was created, so it's doesn't have this changes.

[garrethdev]

@Arilas If you do a heroku restart or clear cache that should fix it. Or if you redeploy.

[garrethdev]

After reloading the page

[Arilas]

@GarrethDottin Is this instance uses the same database as live? Because If yes, changes doesn't work because notifications is populated from live site, that doesn't contains task_id field, because it's client side doesn't send it to server.

[garrethdev]

@Arilas The client side that was testing this was done through the PR request. So any information was sent through a client side that should have the latest changes. If we're still having issues, we should probably review with Tenor @L8D as we talked about before.

Also when I was testing this morning, it was a case of me using the PR environment.

[Arilas]

@Ryan-Parker @GarrethDottin Fixed. Notifications(created in this instance) now Like successfully

[garrethdev]

@Arilas Still Seeing this I created it under the pr request.

[garrethdev]

If you want to test this on the environment I would recommend going into resources in the console and deleting the taskDay in localStorage. From there just start the timer and hit complete timer a bunch of times. This will eventually create a notification

[Arilas]

@Ryan-Parker fixed this. Please run task for at least 5 seconds before click on Complete.