Skip to content

Commit

Permalink
Add todo comment for fixing replacements by reference
Browse files Browse the repository at this point in the history
  • Loading branch information
TrueDoctor authored and Keavon committed Mar 6, 2025
1 parent 5d797aa commit 659f9c6
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ fn upgrade_network(document: &mut DocumentMessageHandler, network_path: &[NodeId
if let Err(e) = upgrade_node_manual_composition(network_interface, node_id, network_path) {
log::error!("Failed to upgrade manual composition for node {node_id}: {e}");
}

// TODO: This does not work for nested nodes because we can't access
// the reference of nodes in subgraphs

// Get node metadata
let node_metadata = match network_metadata.persistent_metadata.node_metadata.get(node_id) {
Some(metadata) => metadata,
Expand Down Expand Up @@ -232,9 +236,6 @@ fn upgrade_network(document: &mut DocumentMessageHandler, network_path: &[NodeId
log::error!("Failed to upgrade node {node_id} from definition: {e}");
}
}

// Recursively upgrade sub-networks if this node has them
// Note: Would need network traversal logic here if nodes can have sub-networks
}

Ok(())
Expand Down

0 comments on commit 659f9c6

Please sign in to comment.