-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64
#2589
base: main
Are you sure you want to change the base?
arm64
#2589
Conversation
Hi @mathieu-benoit ! What do you think is the effort needed to make this work? From comments here it looks like there's still a ton of want for this feature: #622 |
@bourgeoisor and @NimJay, please could you approve the CI tests on this PR? I'd like to see what my latest changes will produce. Thanks! |
This PR has not yet perfectly tested the full
arm64
support, but it's helping make progress towards this goal.Here is what covers this PR:
arm64
support mathieu-benoit/sail-sharp#162 forcartservice
.Here is what this PR is waiting for before going in an official "Ready for review" state from "Draft":
arm64
#2589 (comment)) - This will guarantee thatskaffold run
still works and that the repo still works on the defaultamd64
platform/OS: https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/.github/workflows/ci-pr.yaml#L88C9-L88C21.Here is what this PR is not covering and has not yet tested:
scaffold dev
from anarm64
platform/OSarm64
manifest entry for each container image published at each release of this repo - this needs more investigation. Something to change there https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/docs/releasing/make-docker-images.sh#L43?kubectl apply -f
on anarm64
Kubernetes cluster