Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new GKE cluster for ci-pr.yaml #2418

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Use new GKE cluster for ci-pr.yaml #2418

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dbc3ebb
Use new PR cluster for ci-pr.yaml
NimJay Mar 13, 2024
3d64b09
Fix region in ci-pr.yaml
NimJay Mar 13, 2024
d7c9906
Update ci-main.yaml and cleanup.yaml
NimJay Mar 14, 2024
ba9a76c
Add Terraform for prs-gke-cluster
NimJay Mar 14, 2024
178ab8d
Add README for CI Terraform
NimJay Mar 14, 2024
3619a29
Run terraform fmt
NimJay Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
echo "::set-env name=NAMESPACE::$NAMESPACE"
echo "::set-env name=PR_NUMBER::$PR_NUMBER"

gcloud container clusters get-credentials $PR_CLUSTER --zone $ZONE --project $PROJECT_ID
gcloud container clusters get-credentials $PR_CLUSTER --region $REGION --project $PROJECT_ID
cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
Expand All @@ -83,8 +83,8 @@ jobs:
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
PROJECT_ID: "online-boutique-ci"
PR_CLUSTER: "online-boutique-prs"
ZONE: "us-central1-c"
PR_CLUSTER: "prs-gke-cluster"
REGION: "us-central1"
Copy link
Collaborator Author

@NimJay NimJay Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale for change: Since autopilot = regional and standard = zonal.

- name: Wait For Pods
timeout-minutes: 20
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
NAMESPACE="pr${PR_NUMBER}"
echo "::set-env name=NAMESPACE::$NAMESPACE"

gcloud container clusters get-credentials $PR_CLUSTER --zone $ZONE --project $PROJECT_ID
gcloud container clusters get-credentials $PR_CLUSTER --region $REGION --project $PROJECT_ID
cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
Expand All @@ -85,8 +85,8 @@ jobs:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
PR_NUMBER: ${{ github.event.pull_request.number }}
PROJECT_ID: "online-boutique-ci"
PR_CLUSTER: "online-boutique-prs"
ZONE: "us-central1-c"
PR_CLUSTER: "prs-gke-cluster"
REGION: "us-central1"
- name: Wait For Pods
timeout-minutes: 20
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cleanup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ jobs:
timeout-minutes: 20
run: |
gcloud container clusters get-credentials $PR_CLUSTER \
--zone $ZONE --project $PROJECT_ID
--region $REGION --project $PROJECT_ID
NAMESPACE="pr${PR_NUMBER}"
kubectl delete namespace $NAMESPACE
env:
PROJECT_ID: "online-boutique-ci"
PR_CLUSTER: "online-boutique-prs"
ZONE: "us-central1-c"
PR_CLUSTER: "prs-gke-cluster"
REGION: "us-central1"
PR_NUMBER: ${{ github.event.number }}
Loading