Fix PHP 8 deprecation notice, remove unrequired aliases #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyService, because the name is already in use
|
There seems to be a conflict. To be clear, do changes in no-alias branch fix the unit tests? |
|
I solved the conflict. And yes, this changes solve the unit tests. The error vas provoked because the dependency "guzzlehttp/streams" was removed in previous commits (#84 suggested it) but it was required to run some tests. |
jinglundong
approved these changes
Jan 29, 2023
kappratiksha
added a commit
to kappratiksha/appengine-php-sdk
that referenced
this pull request
Feb 7, 2023
…leCloudPlatform#97)" This reverts commit 0ab9bcb.
jinglundong
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpUnit test working again after #94 @jinglundong