Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit fix --force #1433

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RobMeyer
Copy link

@RobMeyer RobMeyer commented Dec 20, 2024

Easy dependency upgrades. Simply ran npm audit fix --force and (especially) since there were major version upgrades, did some testing after verifying that the build didn't produce any errors.

Testing notes

  • I briefly tested each image format. For each: preview updates after compression completes and is responsive to quality slider changes, download file completes successfully and looks as expected, and console window is free of errors.
  • npm run build completes successfully
  • diffed original index.html against the new one to verify nothing changed in a surprising way. There were only three minor differences, all unique filename suffixes changing in format. For example, initial-app-5976e745.js is now initial-app-5559aaed.js.
  • Note: devtools console shows warnings about scroll blocking non-passive 'wheel' event listeners. These warnings are pre-existing and I think I have a stash with these locally fixed
  • PWA installs and launches fine

Before
33 vulnerabilities (1 low, 7 moderate, 21 high, 4 critical)

After
found 0 vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant