Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search loading state #2684

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Fix search loading state #2684

merged 6 commits into from
Jan 8, 2025
+6 −1

Conversation

clairechabas
Copy link
Contributor

Currently the loading state is based on the results array being undefined which includes the query object meaning the array will be defined way before it's populated with the actual result items, causing the loading state to never show.

@linear Linear
Copy link

linear bot commented Jan 7, 2025

RND-5920 GBO: search doesn't seem to be triggered

@clairechabas clairechabas requested a review from emmerich January 7, 2025 15:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 16ca814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

GitBook Preview
Latest commit: https://8191bdbb.gitbook-open.pages.dev
PR: https://pr2684.gitbook-open.pages.dev

@argos-ci Argos CI
Copy link

argos-ci bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 83 changed Jan 8, 2025, 10:48 AM

emmerich
emmerich reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the changeset :)

packages/gitbook/src/components/Search/SearchResults.tsx Outdated Show resolved Hide resolved
@clairechabas
Improve logic and add update changeset
4b83600
@clairechabas
Merge branch 'main' into claire/rnd-5920-gbo-search-doesnt-seem-to-be…
ec8a4bb 
…-triggered

* main:
  Improve emoji setup (#2688)
  Fix Sentry instrumentation server-side (#2690)
  Fix pass Sentry release properly (#2687)
  Even safer local storage... (#2686)
  Fix empty sitemap (#2685)
  Various fixes (#2683)
  Set Sentry release (#2682)
@clairechabas
Merge branch 'main' into claire/rnd-5920-gbo-search-doesnt-seem-to-be…
dee7ddf 
…-triggered

* main:
  improve browser support (#2693)
  Move instrumentation to src folder (#2691)
@clairechabas
Merge branch 'main' into claire/rnd-5920-gbo-search-doesnt-seem-to-be…
50f69ba 
…-triggered

* main:
  Improve scroll listener (#2692)
@clairechabas
Merge branch 'main' into claire/rnd-5920-gbo-search-doesnt-seem-to-be…
16ca814 
…-triggered

* main:
  Simplify useHash algo used (#2689)
@clairechabas clairechabas merged commit 300f7bf into main Jan 8, 2025
9 checks passed
@clairechabas clairechabas deleted the claire/rnd-5920-gbo-search-doesnt-seem-to-be-triggered branch January 8, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmerich emmerich emmerich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clairechabas @emmerich