Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position the variant picker in the ToC #2632

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Position the variant picker in the ToC #2632

wants to merge 30 commits into from

Conversation

valentin0h
Copy link
Contributor

@valentin0h valentin0h commented Dec 16, 2024 •
edited
Loading

  • Move from header to the top of the ToC (fixes various issues with logo sizes)
  • Improve overall styling

Before and after screenshots 👇

CleanShot 2024-12-16 at 10 36 12@2x
CleanShot 2024-12-16 at 10 36 31@2x

CleanShot 2024-12-16 at 10 33 15@2x
CleanShot 2024-12-16 at 10 33 40@2x

CleanShot 2024-12-16 at 10 32 18@2x
CleanShot 2024-12-16 at 10 32 43@2x

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c2b7bf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

GitBook Preview
Latest commit: https://f2f166c8.gitbook-open.pages.dev
PR: https://pr2632.gitbook-open.pages.dev

@argos-ci Argos CI
Copy link

argos-ci bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 272 changed Jan 8, 2025, 4:58 PM

valentin0h and others added 24 commits December 18, 2024 17:15
@valentin0h
Bump API version
67b9e41
@valentin0h
Remove compact header
949987d
@valentin0h
add background test
d3eef16
@valentin0h
less drastic offset
1b4d94d
@zenoachtig
First pass
02b4d2c
@zenoachtig
Redo positioning and filled bg
fab72d4
@zenoachtig
Fix default list style
9c5df67
@zenoachtig
Add sidebar-list-line and sidebar-list-pill styles
04e977d
@zenoachtig
Merge branch 'main' into rnd-5808-sidebar-new-style-settings-gbo
7051e2a
@zenoachtig
Lint
51719db
@zenoachtig
Restyle page aside to use sidebar list styles
be7d604
@zenoachtig
Improve padding
4a7f6a1
@zenoachtig
Fix border when there is no page index
0cf933c
@zenoachtig
Accessible styling
816da18
@zenoachtig
Alignment and overflow fixes
b64a176
@zenoachtig
Merge branch 'main' into rnd-5808-sidebar-new-style-settings-gbo
958a7e9
@zenoachtig
Update TableOfContents.tsx
7104adc
@zenoachtig
Merge branch 'rnd-5808-sidebar-new-style-settings-gbo' into style-pag…
5643970 
…e-aside
@zenoachtig
Better styling for fixed API block aside nav
0e24084
@zenoachtig
Remove comments
9cab85c
@zenoachtig
Fix padding of feedback container
c7f55a5
@zenoachtig
Merge branch 'style-page-aside' into variant-dropdown-styling
15b67b0
@zenoachtig
Restyle variant selector
e3bff9c
@zenoachtig
If no-toc, put variant selector in header
93e1326 
And make it wrap on mobile to accomodate all necessary items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenoachtig zenoachtig Awaiting requested review from zenoachtig

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin0h @zenoachtig