Input customization point #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorasl
force-pushed
the
input-customization-point
branch
from
b63c230 to
7e39198
Compare
rnystrom
added a commit
that referenced
this pull request
Apr 19, 2018
|
I'm actually reverting this b/c I didn't really think about the long term effects of adding a breaking change w/out a plan for #53. |
|
What are the next steps? Is the solution to this should not introduce any breaking changes? |
|
@viktorasl breaking changes are fine since this lib is so young, but I think we need to know why this change is required in the long run Sent with GitHawk |
|
My plan is that this implementation will allow manipulating text that will be changed by conforming to IMHO that's pretty convenient way to tackle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originated from #53.
As far as I can see there is no trivial way to do this, so I went the easiest way and forced developers implementing listeners to be cautious and do be aware about might-be-clashing manipulations of text and/or attributes.
7e39198 tinily improved removing of autocompleted text leaving preceding character (which is probably a space AFAIK). (e.g "Hello @SD10" becomes "Hello " instead of "Hello")