Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfc: add scandoas domain and references #2375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

nfc: add scandoas domain and references #2375

wants to merge 1 commit into from

Conversation

elidana
Copy link
Contributor

@elidana elidana commented Mar 3, 2025

Hi @rumachan ,

can you please review this? It is

  • adding gnss domain description (as in Tilde api)
  • add scandoas domain (was missing) and related citation

Thanks!

@elidana elidana requested a review from rumachan March 3, 2025 04:41
@elidana elidana requested review from ozym and a team as code owners March 3, 2025 04:41
Copy link
Contributor

@rumachan rumachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In domains.csv "scandoas,Continuous sulphur dioxide gas emission rates and supporting data". Remove "and supporting data". Description was written when we considered including wind, quality, etc supporting data, but we decided not to, and it was never changed.

In datasets.csv, problem with "scandoas,EN,Gns2022b,true" is that EN is described as "GeoNet environmental data using low rate data collection platform network" in network/networks.csv, which isn't the case for scanDOAS. Think we need to generalise network/networks.csv to "GeoNet environmental data using various automatic low rate data collection networks"as that will include scanDOAS and any future "low rate" automatic collection system we might use.

@elidana
Copy link
Contributor Author

elidana commented Mar 3, 2025

Thanks @rumachan !

  • domain description: here I was just capturing the description used in Tilde (https://tilde.geonet.org.nz/v4/dataSummary/scandoas) - shall this one change to? My plan, if possible, would be to finalise this delta table and then manage Tilde domain description through this one (and developmnent work and perhaps some proper review of those tables is needed before this can happen)
  • for the EN i wasn't sure either. So you confirm is correct to use it as network code for scandoas as used in delta? Or is there another one? I had a look around and was only able to find EN (but I might well be wrong and did big mistakes). Happy to change the network description for EN if that's the best option

will wait to hear back from you and then apply the changes

@rumachan
Copy link
Contributor

rumachan commented Mar 3, 2025

Yes, the description used in Tilde for scanDOAS needs to be changed as its just SO2 (maybe CH4 in the future), but no supporting data. I just never got round to it.

I checked also. scanDOAS stations are assigned to EN network (by me). The EN network description is quite specific (to LRDCP) but to use is for scanDOAS we need to make the description a little more general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants