-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gallery example showing the usage of Figure.hlines and Figure.vlines #3755
Conversation
/format |
/format |
/format |
Please ignore the failing "Style Checks", which will be addressed in #3763. |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@michaelgrund Thanks for making the gallery example! I feel it's already in great shape! My last comment is about the figure title. Currently we use hlines/vlines Cartesian/polar/geographic. Maybe Cartesian/Polar/Geographic hlines/vlines are better? |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my comment regarding mentioning the “Line style” Gallery example, I think this Gallery examples look nice 🙂! Thanks @michaelgrund for your patience with all the formulations updates.
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Description of proposed changes
This PR adds a gallery example to show how the
Figure.hlines
andFigure.vlines
methods can be used.Related to #923 and #3726
Preview: https://pygmt-dev--3755.org.readthedocs.build/en/3755/gallery/lines/hlines_vlines.html#
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code