Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Datasets: Use complete word for units in "load_remote_dataset" and related tests #3725

Merged
merged 5 commits into from
Dec 26, 2024
Merged

Remote Datasets: Use complete word for units in "load_remote_dataset" and related tests #3725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32e75f9
Use consistently complete word for units
yvonnefroehlich Dec 26, 2024
2e4ff3e
Fix typo
yvonnefroehlich Dec 26, 2024
676ece8
Only change datasets having unit meters
yvonnefroehlich Dec 26, 2024
9d49129
Merge branch 'main' into make-unit-consistent-datasets
yvonnefroehlich Dec 26, 2024
74dcfdf
Merge branch 'main' into make-unit-consistent-datasets
yvonnefroehlich Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pygmt/datasets/load_remote_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class GMTRemoteDataset(NamedTuple):
),
"earth_dist": GMTRemoteDataset(
description="GSHHG Earth distance to shoreline",
units="km",
units="kilometers",
extra_attributes={"horizontal_datum": "WGS84"},
resolutions={
"01d": Resolution("01d"),
Expand Down Expand Up @@ -152,7 +152,7 @@ class GMTRemoteDataset(NamedTuple):
),
"earth_geoid": GMTRemoteDataset(
description="EGM2008 Earth geoid",
units="m",
units="meters",
extra_attributes={"horizontal_datum": "WGS84"},
resolutions={
"01d": Resolution("01d"),
Expand Down
2 changes: 1 addition & 1 deletion pygmt/tests/test_datasets_earth_dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_earth_dist_01d():
data = load_earth_dist(resolution="01d")
assert data.name == "z"
assert data.attrs["description"] == "GSHHG Earth distance to shoreline"
assert data.attrs["units"] == "km"
assert data.attrs["units"] == "kilometers"
assert data.attrs["horizontal_datum"] == "WGS84"
assert data.shape == (181, 361)
assert data.gmt.registration == 0
Expand Down
2 changes: 1 addition & 1 deletion pygmt/tests/test_datasets_earth_geoid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_earth_geoid_01d():
assert data.name == "z"
assert data.attrs["long_name"] == "geoid (m)"
assert data.attrs["description"] == "EGM2008 Earth geoid"
assert data.attrs["units"] == "m"
assert data.attrs["units"] == "meters"
assert data.attrs["horizontal_datum"] == "WGS84"
assert data.shape == (181, 361)
assert data.gmt.registration == 0
Expand Down
Loading