Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the built-in patterns in the Technical Reference section #3466

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Document the built-in patterns in the Technical Reference section #3466

merged 8 commits into from
Oct 4, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 29, 2024 •
edited
Loading

@seisman seisman added the documentation Improvements or additions to documentation label Sep 29, 2024
@seisman seisman added this to the 0.14.0 milestone Sep 29, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label Sep 29, 2024
yvonnefroehlich
yvonnefroehlich reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the "Technical Reference" section. Will look at this PR tomorrow (or in the next days) in more detail.

yvonnefroehlich
yvonnefroehlich reviewed Sep 30, 2024
View reviewed changes
examples/gallery/symbols/patterns.py Outdated Show resolved Hide resolved
examples/gallery/symbols/patterns.py Outdated Show resolved Hide resolved
examples/gallery/symbols/patterns.py Outdated Show resolved Hide resolved
yvonnefroehlich
yvonnefroehlich approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (besides the minor comment)!

examples/gallery/symbols/patterns.py Outdated Show resolved Hide resolved
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Oct 4, 2024
michaelgrund
michaelgrund approved these changes Oct 4, 2024
View reviewed changes
examples/gallery/symbols/patterns.py Outdated Show resolved Hide resolved
@seisman seisman merged commit 7f39a7d into main Oct 4, 2024
8 checks passed
@seisman seisman deleted the doc/patterns branch October 4, 2024 15:27
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @michaelgrund @yvonnefroehlich