Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove the pytest-benchmark plugin from the benchmarks workflow #2947

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 2, 2024

The workflow runs (https://github.com/GenericMappingTools/pygmt/actions/runs/7383547777/job/20084932197) says:

 ============================= test session starts ==============================
  platform linux -- Python 3.12.1, pytest-7.4.4, pluggy-1.3.0 -- /usr/share/miniconda/bin/python
  codspeed: 2.2.0 (callgraph: enabled)
  CodSpeed had to disable the following plugins: pytest-benchmark
  cachedir: .pytest_cache
  benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
  Matplotlib: 3.8.2
  Freetype: 2.12.1
  rootdir: /home/runner/work/pygmt/pygmt
  configfile: pyproject.toml
  plugins: benchmark-4.0.0, codspeed-2.2.0, mpl-0.16.1
  collecting ... collected 697 items / 631 deselected / 6 skipped / 66 selected

It means the pytest-benchmark plugin is not needed.

Patches #2908.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Jan 2, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 2, 2024
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 3, 2024
@seisman seisman merged commit ae65275 into main Jan 3, 2024
17 of 18 checks passed
@seisman seisman deleted the ci/benchmark branch January 3, 2024 10:35
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants