-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute shell checks and improve output #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More specifically, fix spacing issues in the output, run checks in order (regardless of type), and print summary statement in the same style as GatorGradle. These changes will make GatorGrade feel very similar to current GatorGradle users.
gvanzin-allegheny
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
Michionlion
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Looking forward to seeing it in action.
gkapfham
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute shell checks and improve output
Description
Previously, GatorGrade could parse shell checks from a
gatorgrade.yml
, but it would not execute these shell checks. The changes in this PR support the execution of these shell checks. Additionally, this PR adds some improvements to the output of GatorGrade so that it more closely resembles the output of GatorGradle.The current output of GatorGrade in
main
, when run on the GatorGrade Hello World example:The new output of GatorGrade with the changes in this branch:
The key differences in the output are:
gatorgrade.yml
To support these changes, some of the
input
and much of theoutput
code has been refactored. Because of this, I am adding as reviewers the members of the input and output teams in case anyone is available and would like to review this refactoring 🙂Linked Issues
Closes: #13
Type of Change
Contributors
Reminder