Improve cinterface #2366
Open
Improve cinterface #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field "identity" previously clashed with the method "identity"
This also fixes a few issues related to type conversions before data is sent to the engine function. Squash
This was referenced Aug 3, 2019
mNSEntry can be null if there is no TorqueScript defintion, but there could still be a result from an externally defined source. ´ Furthermore fixes an issue where StringStackConsoleWrapper would die before the value was read.
|
Since this is hard-to-test without actually using the C-Interface for something, this project might be useful: https://github.com/lukaspj/T3D.Net-BaseGame It has a pre-compiled version of this branch included already, and is set up with a SpectatorGameplay module written (mostly) in C#. Edit: Also Travis CI failed on clang on the last commit, but I do not believe this to be related to code, rather it seems to be an odd hiccup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CInterface improvements
Breaking changes
Name-clash fixes means that some members have been renamed, possibly breaking any scripts using these members.
AFX Members:
afxPhraseEffectData::addEffect-> pushEffectafxMagicSpellData::addCastingEffect-> pushCastingEffectafxMagicSpellData::addLaunchEffect-> pushLaunchEffectafxMagicSpellData::addDeliveryEffect-> pushDeliveryEffectafxMagicSpellData::addImpactEffect-> pushImpactEffectafxEffectronData::addEffect-> pushEffectafxEffectGroupData::addEffect-> pushEffectOther Members:
GuiSpeedometerHud::mColor-> mNeedleColor (Maybe we could just use the parent class' mColor here instead?)TriggerComponent::onEnterViewCmd->onEnterViewTriggerComponent::onExitViewCmd->onExitViewTriggerComponent::onUpdateInViewCmd->onUpdateInViewTriggerComponent::onUpdateOutOfViewCmd->onUpdateOutOfViewPostEffect::isEnabled-> enabledGuiFilterCtrl::identity-> resetFilteringSFXDescription::reverbModTime-> reverbModDepth (dunno if it pointed to time or depth before, now there is one for each)GuiScriptNotifyCtrl::onChildAdded-> notifyOnChildAddedGuiScriptNotifyCtrl::onChildRemoved-> notifyOnChildRemovedGuiScriptNotifyCtrl::onChildResized-> notifyOnChildResizedGuiScriptNotifyCtrl::onParentResized-> notifyOnParentResizedGuiScriptNotifyCtrl::onResize-> notifyOnResizeGuiScriptNotifyCtrl::onLoseFirstResponder-> notifyOnLoseFirstResponderGuiScriptNotifyCtrl::onGainFirstResponder-> notifyOnGainFirstResponderOther (possibly breaking) changes
I also changed the default value of
UndoManager::pushCompoundfrom """" to "". Would like a review of whether this is valid or a misunderstanding on my part.