Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Entries component #310

Open
21 tasks
jimmoffet opened this issue Sep 9, 2024 · 5 comments
Open
21 tasks

Multiple Entries component #310

jimmoffet opened this issue Sep 9, 2024 · 5 comments
Assignees
Labels
story User story

Comments

@jimmoffet
Copy link
Contributor

jimmoffet commented Sep 9, 2024

Overview

As a form builder, I would like provide an input that allows the user to enter an undetermined number of input fields, so that I can collect information where the answers might vary from person-to-person (e.g. job history over the last 7 years, residential addresses, education, dependent info, etc).

Context

Optional: Any reference material or thoughts we may need for later reference, or assumptions of prior or future work that's out of scope for this story.

  • [ ]

Acceptance Criteria

Required outcomes of the story

  • [ ]

Research Questions

  • Optional: Any initial questions for research

Tasks

Research, design, and engineering work needed to complete the story.

  • [ ]

Definition of done

The "definition of done" ensures our quality standards are met with each bit of user-facing behavior we add. Everything that can be done incrementally should be done incrementally, while the context and details are fresh. If it’s inefficient or “hard” to do so, the team should figure out why and add OPEX/DEVEX backlog items to make it easier and more efficient.

  • Behavior
    • Acceptance criteria met
    • Implementation matches design decisions
  • Documentation
    • ADRs (/documents/adr folder)
    • Relevant README.md(s)
  • Code quality
    • Code refactored for clarity and no design/technical debt
    • Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies; dependency rule followed
    • Code is reviewed by team member
    • Code quality checks passed
  • Security and privacy
    • Automated security and privacy gates passed
  • Testing tasks completed
    • Automated tests pass
    • Unit test coverage of our code >= 90%
  • Build and deploy
    • Build process updated
    • API(s) are versioned
    • Feature toggles created and/or deleted. Document the feature toggle
    • Source code is merged to the main branch

Decisions

  • Optional: Any decisions we've made while working on this story

Early image of UI for reference and designer reference:

Image

@jimmoffet jimmoffet added the story User story label Sep 9, 2024
@jimmoffet jimmoffet changed the title STUB: Multiple Entries component STUB: Multiple Entries component feasiblity spike Sep 9, 2024
@ethangardner
Copy link
Contributor

Possible inspiration - https://www.advancedcustomfields.com/resources/repeater/.

@ethangardner ethangardner self-assigned this Sep 9, 2024
@JennyRichards-Flexion JennyRichards-Flexion changed the title STUB: Multiple Entries component feasiblity spike Multiple Entries component Sep 24, 2024
@ethangardner ethangardner linked a pull request Oct 11, 2024 that will close this issue
@JennyRichards-Flexion
Copy link
Contributor

JennyRichards-Flexion commented Oct 15, 2024

Functionally done but the tests are not good on the user-facing side.
Next thing - testing type of thing for accessibility and E2E testing.
Tests for this item do not apply to other components.

@jimmoffet
Copy link
Contributor Author

@ethangardner Is this blocked on enhanced tests or do we need to wait for the javascript-blocked handling mentioned in the PR before merging?

Can we merge this and create a new ticket for enhancements, better tests?

@ethangardner
Copy link
Contributor

@jimmoffet The tests aren't the reason for the hold up. Those are fine. It's blocked because there were comments in the code review that Dan left for me that he believes might be solved by the form submission branch he's working on. I am in the middle of code review on his branch, and once his changes are in main, we'll pair on the integration work to see if that solves both issues.

@jimmoffet
Copy link
Contributor Author

Here's the current PR that would close this ticket #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story User story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants