Skip to content

Commit

Permalink
fix issue where pnpm test was not terminating on test completion (#451)
Browse files Browse the repository at this point in the history
Without the env var, the storybook browser tests kept the web socket connection
open indefinitely, causing our pre-commit hooks to never exit and blocking commits
unless we ran it with --no-verify
  • Loading branch information
ethangardner authored Jan 17, 2025
1 parent 7c2e9c5 commit ef8c283
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
pnpm lint
pnpm format
pnpm test
pnpm test:ci
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"lint": "turbo run lint",
"pages": "rm -rf node_modules && npm i -g pnpm turbo && pnpm i && pnpm build && ln -sf ./apps/spotlight/dist _site",
"test": "vitest run",
"test:ci": "vitest run # --coverage.enabled --coverage.provider=v8 --coverage.reporter=text --coverage.reporter=json-summary --coverage.reporter=json --coverage.reportOnFailure",
"test:ci": "CI=true vitest run # --coverage.enabled --coverage.provider=v8 --coverage.reporter=text --coverage.reporter=json-summary --coverage.reporter=json --coverage.reportOnFailure",
"test:infra": "turbo run --filter=infra-cdktf test",
"typecheck": "tsc --build --noEmit",
"prepare": "husky"
Expand Down

0 comments on commit ef8c283

Please sign in to comment.