Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Notify user of unknown support form errors #12555

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

esizer
Copy link
Member

@esizer esizer commented Jan 22, 2025

πŸ€– Resolves #12473

πŸ‘‹ Introduction

Refactors the support form in order to handle unknown errors.

πŸ•΅οΈ Details

The form was handling all errors from the response except edge cases where we had no response to work with (500). This refactors it to handle that edge case and return the default error.

πŸ§ͺ Testing

  1. Build pnpm run dev:fresh
  2. Navigate to support form /support
  3. Turn off the web container
  4. Submit the form
  5. Confirm an error toast appears

Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested happy path and Freshdesk ticket created successfully. Tested when webserver stopped and got expected error.

Screenshot

Screen Shot 2025-01-22 at 10 22 18

@esizer esizer marked this pull request as ready for review January 22, 2025 15:27
@esizer esizer added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 814be2d Jan 22, 2025
16 checks passed
@esizer esizer deleted the 12473-notify-users-support-form-errors branch January 22, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› No indication for failed support ticket submission
2 participants