Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Try stabilizing pool-candidates-actions.spec.ts #12529

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[Fix] Try stabilizing pool-candidates-actions.spec.ts #12529

merged 1 commit into from
Jan 20, 2025

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Jan 17, 2025

👋 Introduction

The verification and notes test is failing a bunch, sometimes, and it is driving me bananas

🧪 Testing

  1. Runs well locally, and in CI

@vd1992 vd1992 requested a review from esizer January 17, 2025 23:10
esizer
esizer approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard top test since I can't reproduce but seems to be okay for now 👍

@vd1992 vd1992 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 865f498 Jan 20, 2025
16 checks passed
@vd1992 vd1992 deleted the fix-try-stabilize-pool-candidate-actions-spec branch January 20, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vd1992 @esizer