Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add tests for asset visibility and management on Testnet FE-1151 #1718

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

nelitow
Copy link
Contributor

@nelitow nelitow commented Dec 14, 2024

Move the assets test to the same structure as the app tests for a cleaner setup.

@nelitow nelitow changed the title test(e2e): add tests for asset visibility and management on Testnet test(e2e): add tests for asset visibility and management on Testnet FE-1151 Dec 14, 2024
arthurgeron
arthurgeron previously approved these changes Dec 14, 2024
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the files that have the .testnet we can remove it.

the only file that needs the .testnet is the yaml if it is specific for it, like we have for tests-testnet.yaml and tests-devnet.yaml. all the rest should be flexible and dont be direct for one network

@nelitow nelitow enabled auto-merge (squash) December 16, 2024 23:57
@nelitow nelitow dismissed LuizAsFight’s stale review December 21, 2024 21:34

Stale review, and Branas and Arhur both approved.

@nelitow nelitow merged commit 7fcfee7 into master Dec 21, 2024
18 checks passed
@nelitow nelitow deleted the nj/test/update-assets-e2e-structure branch December 21, 2024 21:34
LuizAsFight pushed a commit that referenced this pull request Dec 28, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## @fuels/[email protected]

### Minor Changes

- [#1741](#1741)
[`197d1758`](197d175)
Thanks [@nelitow](https://github.com/nelitow)! - Update @fuels packages
to implement localStorage fix.

## [email protected]

### Minor Changes

- [#1741](#1741)
[`197d1758`](197d175)
Thanks [@nelitow](https://github.com/nelitow)! - Update @fuels packages
to implement localStorage fix.

### Patch Changes

- [#1718](#1718)
[`7fcfee7d`](7fcfee7)
Thanks [@nelitow](https://github.com/nelitow)! - Update E2E setup

- [#1742](#1742)
[`4bd6e86b`](4bd6e86)
Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: add OPFS
backup

- Updated dependencies
\[[`197d1758`](197d175)]:
    -   @fuels/[email protected]
    -   @fuel-wallet/[email protected]

## @fuel-wallet/[email protected]



## @fuel-wallet/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants