chore(e2e): Added support for the 'chrome-dev' channel in Playwright FE-803 #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration. - Updated GitHub Actions workflow to install both Chromium and Chrome Dev browsers for E2E testing.
nelitow
requested review from
luizstacio,
pedronauck,
LuizAsFight,
helciofranco,
arthurgeron and
rodrigobranas
as code owners
…nd adjust CI workflow for E2E tests
…ser installations for improved clarity
…me-beta' alongside 'chromium' for enhanced E2E testing
This reverts commit 5f03b96.
…omium' and use 'chrome-beta' for E2E testing
This reverts commit 8183d07.
LuizAsFight
requested changes
Dec 6, 2024
There was a problem hiding this comment.
working on betha doesnt mean it will work on stable, we need both.
- the stable one will be Required
- the dev one will not be Required (which means will not block the PRs if it fails)
at the end of the day, the dev one will be just a trigger for us to recognize we need to fix something in advance
…g CI workflow - Updated action.yaml to install both Chrome and Chrome Beta browsers for E2E tests. - Modified the E2E test commands to run tests for Chrome Stable and Chrome Beta, with environment variables for configuration. - Added a new project configuration for Chrome in playwright.config.ts to support the new testing setup.
- Added a required input for browser selection (chromium or chrome-beta) in action.yaml. - Updated E2E test commands to dynamically run tests based on the selected browser. - Created a new CI job for testing with Chrome Beta, alongside the existing Chrome Stable job. - Modified playwright.config.ts to reflect the change from 'chrome' to 'chromium' for consistency in project naming.
…FuelLabs/fuels-wallet into nj/tests/run-tets-on-chrome-dev
- Eliminated the maxFailures configuration to streamline test execution in CI environments. - This change aligns with the recent adjustments to retries based on the CI context.
LuizAsFight
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddReplacechromiumwithchrome-betatests as a way to catch breaking changes early on.I would have chosen the
devchannel as it gives us 9 to 12 weeks to catch those changes, as thebetachannel would only give 4 to 6 weeks and theCanaryversion is too unstable, butdevis not available on playwright at the moment.Decided to replace to the beta version instead of running on both as to not increase the test time. If it runs on beta we can be safe that it runs on stable.