Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generation of docker images on release #2631

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add generation of docker images on release #2631

wants to merge 2 commits into from

Conversation

AurelienFT
Copy link
Contributor

Description

Docker Images are useful for our DevOps team. In case of release we should generate them automatically for them and all the users.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@MitchTurner
Copy link
Member

Do we know the history of why this changed?

@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Jan 24, 2025
@AurelienFT
Copy link
Contributor Author

Do we know the history of why this changed?

To lower CI times on all branches because it was barely used and increased CI times by 2 for every push.

MitchTurner
MitchTurner previously approved these changes Jan 24, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchTurner MitchTurner MitchTurner left review comments

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @MitchTurner