Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing messages after import on Android 14 due to subscriptionId #192

Merged

Conversation

tom93
Copy link
Contributor

@tom93 tom93 commented Jul 15, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

On Android 14, imported messages are not visible if their subscriptionId[1] does not correspond to one of the SIMs in the device. As a workaround, we set subscriptionId to -1 ("unknown") on all messages during import.

This does mean that when exporting then importing on the same device, the SIM associations will be lost. But that doesn't seem noticeable.

Credit: SMS Import / Export app, https://www.github.com/tmo1/sms-ie/issues/128

[1] https://developer.android.com/identity/user-data-ids#mobile-subscription-status

Fixes the following issue(s)

Acknowledgement

On Android 14, imported messages are not visible if their
subscriptionId[1] does not correspond to one of the SIMs in the
device. As a workaround, we set subscriptionId to -1 ("unknown") on
all messages during import.

This does mean that when exporting then importing on the same device,
the SIM associations will be lost. But that doesn't seem noticeable.

Credit: SMS Import / Export app,
https://www.github.com/tmo1/sms-ie/issues/128

Fixes FossifyOrg#191.

[1] https://developer.android.com/identity/user-data-ids#mobile-subscription-status
@naveensingh naveensingh merged commit c19277a into FossifyOrg:master Dec 25, 2024
1 check passed
@BlastboomStrice
Copy link

Hello and happy holidays!

May I ask, does this mean

  1. Newer versions of this app don't export/import messages with their actual subscriptionId
    Or
  2. On android 14+ the app doesn't export/import messages with their actual subscriptionId
    Or
  3. Newer versions of this app now import/export messages with their actual subscriptionId?

I don't know if I should tag anyone or if I should ask elsewhere😅

@naveensingh
Copy link
Member

None of the above.

On android 14+ the app does NOT import messages with their actual subscriptionId

This is what's likely to happen in the next release.

Happy holidays!

@tom93 tom93 deleted the pr/fix-subscriptionId-android-14 branch December 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import doesn't include all messages on Android 14 due to subscriptionId issue
3 participants