-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usecase to set external camera ip [#55] #57
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
71a649d
add usecase to set external camera ip [#55]
fetiu f74e293
add AppPolicy for the default value of externalCameraIp app preferenc…
fetiu fe2ddb2
minor typo correction ex> to e.g.
fetiu ae38dab
add UseCase & Interface for setExternalCameraIP
fetiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
domain/src/main/java/com/foke/together/domain/input/GetExternalCameraIPInterface.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package com.foke.together.domain.input | ||
|
||
import com.foke.together.domain.interactor.entity.ExternalCameraIP | ||
import kotlinx.coroutines.flow.Flow | ||
|
||
interface GetExternalCameraIPInterface { | ||
operator fun invoke(): Flow<ExternalCameraIP> | ||
} |
7 changes: 7 additions & 0 deletions
7
domain/src/main/java/com/foke/together/domain/input/SetExternalCameraIPInterface.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.foke.together.domain.input | ||
|
||
import com.foke.together.domain.interactor.entity.ExternalCameraIP | ||
|
||
interface SetExternalCameraIPInterface { | ||
suspend operator fun invoke(externalCameraIP: ExternalCameraIP) | ||
} |
18 changes: 18 additions & 0 deletions
18
domain/src/main/java/com/foke/together/domain/interactor/GetExternalCameraIPUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.foke.together.domain.interactor | ||
|
||
|
||
import com.foke.together.domain.input.GetExternalCameraIPInterface | ||
import com.foke.together.domain.interactor.entity.ExternalCameraIP | ||
import com.foke.together.domain.output.AppPreferenceInterface | ||
import kotlinx.coroutines.flow.Flow | ||
import kotlinx.coroutines.flow.map | ||
import javax.inject.Inject | ||
|
||
class GetExternalCameraIPUseCase @Inject constructor( | ||
private val appPreference: AppPreferenceInterface | ||
): GetExternalCameraIPInterface { | ||
override operator fun invoke(): Flow<ExternalCameraIP> = | ||
appPreference.getExternalCameraIP().map { it } | ||
} | ||
|
||
|
16 changes: 16 additions & 0 deletions
16
domain/src/main/java/com/foke/together/domain/interactor/SetExternalCameraIPUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.foke.together.domain.interactor | ||
|
||
|
||
import com.foke.together.domain.input.SetExternalCameraIPInterface | ||
import com.foke.together.domain.interactor.entity.ExternalCameraIP | ||
import com.foke.together.domain.output.AppPreferenceInterface | ||
import javax.inject.Inject | ||
|
||
class SetExternalCameraIPUseCase @Inject constructor( | ||
private val appPreference: AppPreferenceInterface | ||
): SetExternalCameraIPInterface { | ||
override suspend operator fun invoke(externalCameraIP: ExternalCameraIP)= | ||
appPreference.setExternalCameraIP(externalCameraIP) | ||
} | ||
|
||
|
5 changes: 5 additions & 0 deletions
5
domain/src/main/java/com/foke/together/domain/interactor/entity/ExternalCameraIP.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.foke.together.domain.interactor.entity | ||
|
||
data class ExternalCameraIP ( | ||
val address: String, | ||
) |
4 changes: 4 additions & 0 deletions
4
domain/src/main/java/com/foke/together/domain/output/AppPreferenceInterface.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
package com.foke.together.domain.output | ||
|
||
import com.foke.together.domain.interactor.entity.CameraSourceType | ||
import com.foke.together.domain.interactor.entity.ExternalCameraIP | ||
import kotlinx.coroutines.flow.Flow | ||
|
||
interface AppPreferenceInterface { | ||
fun getCameraSourceType(): Flow<CameraSourceType> | ||
suspend fun setCameraSourceType(type: CameraSourceType) | ||
|
||
fun getExternalCameraIP(): Flow<ExternalCameraIP> | ||
suspend fun setExternalCameraIP(ip: ExternalCameraIP) | ||
|
||
suspend fun clearAll() | ||
} |
2 changes: 1 addition & 1 deletion
2
presenter/src/main/java/com/foke/together/presenter/theme/Shape.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package com.foke.together.presenter.theme | ||
|
||
// Defines commonly used or recycled values | ||
// ex> https://github.com/android/compose-samples/blob/main/JetNews/app/src/main/java/com/example/jetnews/ui/theme/Shape.kt | ||
// e.g. https://github.com/android/compose-samples/blob/main/JetNews/app/src/main/java/com/example/jetnews/ui/theme/Shape.kt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.foke.together.util | ||
|
||
object AppPolicy { | ||
const val DEFAULT_EXTERNAL_CAMERA_IP = "0.0.0.0" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
특히 이부분 동작을 어떻게 확인해야하는지 모르겠습니다... 프로토 버프 잘 저장되려나요?ㅋㅋㅋ @DokySp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정상동작 확인했습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
대신 검증해주셔서 감사합니다!