Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation 및 기초 Screen 추가 #24
Navigation 및 기초 Screen 추가 #24
Changes from all commits
b30a0c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소하긴 하지만 여기도 Frame Screen 이 아니라 Share Screen 이어야 할 것 같습니다 😄
굳이 이번에 수정하지 않아도 될 것 같네요 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 내용은 단순 스크린 랜더링 테스트용 아이콘들이어서 삭제할 내용이었습니다.
Screen 작업시에 삭제하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소한 질문: 이
"camera"
는 왜 소문자로 시작하나요? 아래의"Setting"
은 둘 모두 대문자로 시작하는데 이 경우만 일관되지 않길래 하는 가벼운 질문입니다!아닐 가능성이 높지만, 안드로이드 시스템을 잘 몰라서 이게 혹시라도 버그가 될까 싶기도 해서요:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오.. 예리한거 같네요 ㅎㅎ
동작상 문제는 없어보이지만,
Setting
을setting
으로 바꿔야 할 것 같기는 합니다. 둘의 차이가 궁금하기는 하네요!중요한 문제가 아니라면 굳이 이번에 수정하지 않아도 될 것 같네요 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 다음 Screen UI 구현부에서 수정하도록하겠습니다