-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Velopack & Github Action #2616
base: dev
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # Flow.Launcher.Core/Flow.Launcher.Core.csproj # Flow.Launcher/Flow.Launcher.csproj
This comment has been minimized.
This comment has been minimized.
@coderabbitai review |
This is intentional to use the Release Channel Feature. https://docs.velopack.io/packaging/channels |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is fine, but you can rename the two files to their proper name after the pack command. Update only looks at nupkg not the exe/zip, but Scoop, Choco and WinGet will. Additionally, those two names are more user-friendly. |
New-Item $output -ItemType Directory -Force | ||
} | ||
|
||
|
||
function Pack-Squirrel-Installer ($path, $version, $output) { | ||
function Pack-Velopack-Installer($path, $version, $output) | ||
{ | ||
# msbuild based installer generation is not working in appveyor, not sure why | ||
Write-Host "Begin pack squirrel installer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up any comments or references related to Squirrel installer
Checking for new update throws an error message, maybe code hasn't handled when request returns no new version updates. |
I think that's the current behavior? We currently parse the github release ourselves. I don't think the current updater support pre-release...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, current behaviour is not throwing an error when there are no new updates. Please test check for update when there are no more updates. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. Pattern suggestions ✂️ (1)You could add these patterns to
If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
README.md (4)
65-65
: Clarify installation security warning.The warning about security issues during the first-time installation could be clearer. Specify what the user should verify to ensure the downloaded file is safe.
> When installing for the first time, Windows may raise an issue about security due to the code not being signed. If you downloaded from this repo, then you are good to continue the setup. Or download the [early access version](https://github.com/Flow-Launcher/Prereleases/releases).
Tools
LanguageTool
[uncategorized] ~65-~65: When ‘set-up’ is used as a noun or modifier, it needs to be hyphenated.
Context: ...repo, then you are good to continue the set up. Or download the [early access version...(VERB_NOUN_CONFUSION)
125-125
: Clarify drag-and-drop behavior modification keys.The description of how to modify the behavior of drag-and-drop operations using keyboard shortcuts could be more explicit about what each key does.
- Copy/move behavior can be changed via <kbd>Ctrl</kbd> or <kbd>Shift</kbd>, and the operation is displayed on the mouse cursor. + Copy/move behavior can be changed via <kbd>Ctrl</kbd> (copy) or <kbd>Shift</kbd> (move), and the operation is displayed on the mouse cursor.
207-207
: Update user data folder path description for clarity.The description of the user data folder path for the portable version should explicitly mention that it changes based on the installed version of FlowLauncher.
- If using portable, by default: `%LocalAppData%\FlowLauncher\app-<VersionOfYourFlowLauncher>\UserData` + If using the portable version, by default: `%LocalAppData%\FlowLauncher\app-<InstalledVersion>\UserData`
380-380
: Add "please" for politeness.The expression should include "please" to make it more polite.
- If you are unsure of a change you want to make, let us know in the [Discussions](https://github.com/Flow-Launcher/Flow.Launcher/discussions/categories/ideas), otherwise, please consider submitting a pull request. + If you are unsure of a change you want to make, please let us know in the [Discussions](https://github.com/Flow-Launcher/Flow.Launcher/discussions/categories/ideas), otherwise, please consider submitting a pull request.Tools
LanguageTool
[style] ~380-~380: This expression usually appears with a “please” in front of it.
Context: ...re unsure of a change you want to make, let us know in the [Discussions](https://github.com...(INSERT_PLEASE)
Velopack (https://velopack.io/) is the successor of Cloud.Squirrel (https://github.com/clowd/Clowd.Squirrel)
Several change in this pr
%LocalAppData%
as velopack will pack the portable version for us, which doesn't allow us to modify (easily) to insert a custom folder.win-x64-prerelease
channel, while the main repo will havewin-x64-stable
channel. https://docs.velopack.io/packaging/channelsTODO:
Tested:
UserData
folderFuther Consideration:
vpk pack
Note: Maybe we want to squash so revert is easier?