Skip to content

Commit

Permalink
Remove the outdated dependancy tracking. Exclude parent conjuncts fro…
Browse files Browse the repository at this point in the history
…m the invariant checks.
  • Loading branch information
dyemanov committed Mar 3, 2025
1 parent f7e16a1 commit 04cd8c3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 25 deletions.
24 changes: 0 additions & 24 deletions src/jrd/optimizer/InnerJoin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -587,30 +587,6 @@ River* InnerJoin::formRiver()
}
else
{
StreamList depStreams;

if (optimizer->isSemiJoined() && rsbs.isEmpty())
{
const auto baseStream = getStreamInfo(stream.number);
for (const auto boolean : baseStream->baseConjuncts)
{
if (optimizer->checkEquiJoin(boolean))
{
SortedStreamList nodeStreams;
boolean->collectStreams(nodeStreams);

for (const auto stream : nodeStreams)
{
if (stream != baseStream->number && !depStreams.exist(stream))
depStreams.add(stream);
}
}
}
}

StreamStateHolder stateHolder(csb, depStreams);
stateHolder.deactivate();

rsb = optimizer->generateRetrieval(stream.number, sortPtr, false, false);
}

Expand Down
2 changes: 1 addition & 1 deletion src/jrd/optimizer/Optimizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ RecordSource* Optimizer::compile(BoolExprNodeStack* parentStack)

if (isInnerJoin())
{
for (auto iter = getConjuncts(); iter.hasData(); ++iter)
for (auto iter = getBaseConjuncts(); iter.hasData(); ++iter)
{
if (!(iter & CONJUNCT_USED) &&
iter->deterministic() &&
Expand Down

0 comments on commit 04cd8c3

Please sign in to comment.