Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better kernel api for P/E-cores #515

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

HenrikHolst
Copy link
Contributor

@wereii found a proper kernel way to check for the presence of P- and E-cores so we don't have to check the frequency differences.

Kept the frequency check in case the kernel way does not exist on the users kernel but upped the fail-safe to 10% from 5% to close #498

closes #498
closes #501

@wereii found a proper kernel way to check for the presence of P- and E-cores so we don't have to check the frequency differences.

Kept the frequency check in case the kernel way does not exist on the users kernel but upped the fail-safe to 10% from 5% to close FeralInteractive#498
@afayaz-feral afayaz-feral merged commit 1d9c1e6 into FeralInteractive:master Jan 27, 2025
1 check passed
@afayaz-feral
Copy link
Contributor

Thanks, merged!
Ideally the 10% fail-safe won't even be used, as all affected CPUs are Alder Lake and newer.

@HenrikHolst
Copy link
Contributor Author

Thanks, merged! Ideally the 10% fail-safe won't even be used, as all affected CPUs are Alder Lake and newer.

true but I am unsure on how long the kernel have separated alder lake+ in /sys/ so there might be some older kernels out there without this support.

@afayaz-feral
Copy link
Contributor

That's a good point 🙂
Still annoying that the only documentation I could find was man perf stat

@HenrikHolst
Copy link
Contributor Author

yep, the real one is probably buried deep in some mail to LKML years ago...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants