Feature/ Add channel property and use it for autocomplete and details #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a little more context on this? |
bell-steven
requested changes
Aug 2, 2021
There was a problem hiding this comment.
This should already be supported in the query prop. I don't want to add a separate prop for this.
Would you be open to making a docs change, along with resolving the conflicts and removing whitespace/lint changes?
We pass whatever is in query to autocomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added multiple spots where we were using autocomplete/details and wanted to get an idea what the breakdown was for each implementation which is what
channelsis used for https://developers.google.com/maps/reporting/gmp-reporting#usage-tracking-per-channel.