200 bug cluster node initializes as healthy #252

MuhammadQadora · 2025-02-12T10:42:21Z

…into 200-bug-cluster-node-initializes-as-healthy

coderabbitai · 2025-02-12T10:42:32Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dudizimber

see comments

dudizimber · 2025-02-12T11:26:05Z

falkordb-cluster/cluster-entrypoint.sh

@@ -73,6 +73,9 @@ DATE_NOW=$(date +"%Y%m%d%H%M%S")
 FALKORDB_LOG_FILE_PATH=$(if [[ $SAVE_LOGS_TO_FILE -eq 1 ]]; then echo $DATA_DIR/falkordb_$DATE_NOW.log; else echo ""; fi)
 NODE_CONF_FILE=$DATA_DIR/node.conf

+
+sleep 10


It'd be nice to get an explanation for that

dudizimber · 2025-02-12T11:26:47Z

falkordb-cluster/cluster-entrypoint.sh

-# Run this before health check to prevent client connections until discrepancies are resolved.
-meet_unknown_nodes
-ensure_replica_connects_to_the_right_master_ip
-


why are those removed?

dudizimber · 2025-02-12T11:27:09Z

healthcheck_rs/src/main.rs

@@ -26,7 +26,7 @@ fn main() {
 /// # Arguments
 /// 
 /// * `is_sentinel` - A boolean that indicates whether the health check server is for a Redis Sentinel instance.
-fn start_health_check_server(is_sentinel: bool) {
+fn start_probes_check_server(is_sentinel: bool) {


any reason for the name change?

dudizimber · 2025-02-12T11:27:44Z

healthcheck_rs/src/main.rs

@@ -38,14 +38,26 @@ fn start_health_check_server(is_sentinel: bool) {
    let server = Server::new(addr, move |request| {
        router!(request,
            (GET) (/healthcheck) => {


maybe change the route to /liveness?

dudizimber · 2025-02-12T11:28:29Z

healthcheck_rs/src/main.rs

@@ -74,7 +86,7 @@ fn start_health_check_server(is_sentinel: bool) {
 /// # Errors
 /// 
 /// The function returns a RedisError if there is an error connecting to the Redis server.
-fn health_check_handler(is_sentinel: bool) -> Result<bool, redis::RedisError> {
+fn probes_check_handler(is_sentinel: bool,readiness: bool, healthcheck: bool) -> Result<bool, redis::RedisError> {


i don't think aadding bool args are a clean solution. Maybe split into 3 functions and separate common components in util functions

that goes for all functions you added bools as params.
Let's make this easier to read

…into 200-bug-cluster-node-initializes-as-healthy

MuhammadQadora added 14 commits December 22, 2024 16:17

added sleep to debug

824a221

test

4298c01

remove sleep 600

ee6cf93

moved the healthcheck in the entry point

c0b14a0

removed commented part

a0e4141

Merge branch 'main' of https://github.com/FalkorDB/falkordb-omnistrate …

705348d

…into 200-bug-cluster-node-initializes-as-healthy

updated healtch check app

7e8128a

updated healtch check app

e0946e0

updated health check app

15187ff

updated health check app

55aab7c

updated health check app

c2cf7f5

updated health check app

5e3329d

Merge branch 'main' of https://github.com/FalkorDB/falkordb-omnistrate …

5c502e7

…into 200-bug-cluster-node-initializes-as-healthy

Separated healthcheck, readiness, startup probes

fc4d67e

MuhammadQadora requested a review from dudizimber February 12, 2025 10:42

fixed con

5e375fa

dudizimber requested changes Feb 12, 2025

View reviewed changes

MuhammadQadora added 4 commits February 12, 2025 14:13

Merge branch 'main' of https://github.com/FalkorDB/falkordb-omnistrate …

3b3d399

…into 200-bug-cluster-node-initializes-as-healthy

fixed cluster entry

0d410d4

changed healthcheck to liveness

131d13c

refactored main.rs

e470e1e

MuhammadQadora requested a review from barakb February 13, 2025 08:12

MuhammadQadora added 7 commits February 13, 2025 11:21

added dollar sign to the if statement in action hooks

7e3b153

fixed get_redis_url

5c2151a

added print

6ab1f12

added logging

a15c0c1

added logging

af1e9ed

added another log

a143f2d

added more logs

7cc0a63

MuhammadQadora added 2 commits February 14, 2025 19:20

used match

12ced0b

fixed missing return

249c4bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

200 bug cluster node initializes as healthy #252

200 bug cluster node initializes as healthy #252

MuhammadQadora commented Feb 12, 2025

coderabbitai bot commented Feb 12, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

dudizimber left a comment

dudizimber Feb 12, 2025

dudizimber Feb 12, 2025

dudizimber Feb 12, 2025

dudizimber Feb 12, 2025

dudizimber Feb 12, 2025

dudizimber Feb 12, 2025

200 bug cluster node initializes as healthy #252

Are you sure you want to change the base?

200 bug cluster node initializes as healthy #252

Conversation

MuhammadQadora commented Feb 12, 2025

coderabbitai bot commented Feb 12, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

dudizimber left a comment

Choose a reason for hiding this comment

dudizimber Feb 12, 2025

Choose a reason for hiding this comment

dudizimber Feb 12, 2025

Choose a reason for hiding this comment

dudizimber Feb 12, 2025

Choose a reason for hiding this comment

dudizimber Feb 12, 2025

Choose a reason for hiding this comment

dudizimber Feb 12, 2025

Choose a reason for hiding this comment

dudizimber Feb 12, 2025

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)