fix dialogs

FalkorDB · Jan 8, 2025 · cc959bf · cc959bf
1 parent cd44bcf
commit cc959bf
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 7 deletions.
diff --git a/app/components/CreateGraph.tsx b/app/components/CreateGraph.tsx
@@ -2,7 +2,7 @@
 
 "use client"
 
-import { Dispatch, SetStateAction, useState } from "react"
+import { useState } from "react"
 import { AlertCircle, PlusCircle } from "lucide-react"
 import { prepareArg, securedFetch } from "@/lib/utils"
 import { useToast } from "@/components/ui/use-toast"
@@ -12,7 +12,7 @@ import CloseDialog from "./CloseDialog"
 import Input from "./ui/Input"
 
 interface Props {
-    onSetGraphName: Dispatch<SetStateAction<string>>
+    onSetGraphName: (name: string) => void
     type: string
     trigger?: React.ReactNode
 }

diff --git a/app/graph/Tutorial.tsx b/app/graph/Tutorial.tsx
@@ -1,8 +1,9 @@
 import { Carousel, CarouselContent, CarouselItem, CarouselNext, CarouselPrevious } from "@/components/ui/carousel";
-import { Drawer, DrawerContent } from "@/components/ui/drawer";
+import { Drawer, DrawerContent, DrawerHeader, DrawerTitle } from "@/components/ui/drawer";
 import { Dispatch, SetStateAction, useEffect, useState } from "react";
 import Link from 'next/link'
 import { Checkbox } from "@/components/ui/checkbox";
+import { VisuallyHidden } from "@radix-ui/react-visually-hidden";
 import CreateGraph from "../components/CreateGraph";
 
 interface Props {
@@ -18,6 +19,11 @@ export default function Tutorial({ onSetGraphName }: Props) {
         setOpen(localStorage.getItem("tutorial") !== "false")
     }, [])
 
+    const handleSetGraphName = (name: string) => {
+        onSetGraphName(name)
+        setOpen(false)
+    }
+
     return (
         <Drawer open={open} onOpenChange={(o) => {
             if (showAgain) {
@@ -26,6 +32,11 @@ export default function Tutorial({ onSetGraphName }: Props) {
             setOpen(o)
         }}>
             <DrawerContent className="flex flex-col">
+                <VisuallyHidden>
+                    <DrawerHeader>
+                        <DrawerTitle/>
+                    </DrawerHeader>
+                </VisuallyHidden>
                 <div className="flex justify-center items-center p-8">
                     <Carousel className="w-1/2 h-1/2">
                         <CarouselContent>
@@ -40,7 +51,7 @@ export default function Tutorial({ onSetGraphName }: Props) {
                             </CarouselItem>
                             <CarouselItem className="border flex flex-col gap-4 justify-center items-center">
                                 <CreateGraph
-                                    onSetGraphName={onSetGraphName}
+                                    onSetGraphName={handleSetGraphName}
                                     type="Graph"
                                 />
                                 <p>

diff --git a/app/settings/users/AddUser.tsx b/app/settings/users/AddUser.tsx
@@ -8,6 +8,7 @@ import { CreateUser } from "@/app/api/user/model";
 import Button from "@/app/components/ui/Button";
 import FormComponent, { Error, Field } from "@/app/components/FormComponent";
 import { Sheet, SheetContent, SheetHeader, SheetTitle, SheetTrigger } from "@/components/ui/sheet";
+import { VisuallyHidden } from "@radix-ui/react-visually-hidden";
 
 export default function AddUser({ onAddUser }: {
     onAddUser: (user: CreateUser) => void
@@ -94,9 +95,11 @@ export default function AddUser({ onAddUser }: {
                 </Button>
             </SheetTrigger>
             <SheetContent className="flex flex-col gap-6">
-                <SheetHeader>
-                    <SheetTitle className="text-2xl text-white">Add User</SheetTitle>
-                </SheetHeader>
+                <VisuallyHidden>
+                    <SheetHeader>
+                        <SheetTitle />
+                    </SheetHeader>
+                </VisuallyHidden>
                 <FormComponent
                     handleSubmit={handleAddUser}
                     fields={fields}

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,6 +32,7 @@
     "@radix-ui/react-tabs": "^1.1.2",
     "@radix-ui/react-toast": "^1.2.4",
     "@radix-ui/react-tooltip": "^1.0.7",
+    "@radix-ui/react-visually-hidden": "^1.1.1",
     "autoprefixer": "^10.4.20",
     "class-variance-authority": "^0.7.0",
     "clsx": "^2.0.0",