fix helm entry, use replica rather than slave, k8s_support.md #44
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
k8s_support.md (2)
Line range hint
40-40: Correct the grammatical error in the description.- This file specify the FalkorDB image... + This file specifies the FalkorDB image...
Line range hint
44-44: Ensure headings are surrounded by blank lines for better readability.+ # Step 2: Install FalkorDB Helm Charts +
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- k8s_support.md (1 hunks)
Additional Context Used
LanguageTool (1)
k8s_support.md (1)
Near line 40: The verb ‘specify’ is plural. Did you mean: “specifies”? Did you use a verb instead of a noun?
Context: ...-release/src/falkordb.so" ``` This file specify the FalkorDB image(you can choose diffe...
Rule ID: PLURAL_VERB_AFTER_THIS
Markdownlint (5)
k8s_support.md (5)
44: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
7: null
Multiple top-level headings in the same document
39: null
Fenced code blocks should be surrounded by blank lines
82: null
Fenced code blocks should have a language specified
88: null
Fenced code blocks should have a language specified
Additional comments not posted (1)
k8s_support.md (1)
36-36: Change from "slave" to "replica" aligns with modern conventions and improves inclusivity.
| @@ -33,7 +33,7 @@ master: | |||
| extraFlags: | |||
| - "--loadmodule /FalkorDB/bin/linux-x64-release/src/falkordb.so" | |||
|
|
|||
| slave: | |||
| replica: | |||
| extraFlags: | |||
| - "--loadmodule /FalkorDB/bin/linux-x64-release/src/falkordb.so" | |||
| ``` | |||
There was a problem hiding this comment.
Ensure fenced code blocks are properly formatted.
+
```yaml
image:
registry: docker.io
repository: falkordb/falkordb
tag: "4.0"
+ helm install -f values.yaml my-falkordb oci://registry-1.docker.io/bitnamicharts/redis
+ REDISCLI_AUTH="$REDIS_PASSWORD" redis-cli -h 127.0.0.1 -p 6379
+ Also applies to: 82-82, 88-88
Follow https://github.com/bitnami/charts/blob/main/bitnami/redis/values.yaml#L633
Summary by CodeRabbit
k8s_support.mdto usereplicainstead ofslavefor configuration settings with FalkorDB to reflect more inclusive language.