Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the table markers #29

Merged
merged 1 commit into from
Mar 10, 2024
+15 −15
Merged

Fixed the table markers #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,21 @@ Values set using `GRAPH.CONFIG SET` are not persisted after server restart.

The following table summarizes which configuration parameters can be set at module load-time and which can also be set at run-time:

| Configuration Parameter | Load-time | Run-time |
| :------- | :----- | :----------- |
| [THREAD_COUNT](#thread_count) | :white_check_mark: | :white_large_square: |
| [CACHE_SIZE](#cache_size) | :white_check_mark: | :white_large_square: |
| [OMP_THREAD_COUNT](#omp_thread_count) | :white_check_mark: | :white_large_square: |
| [NODE_CREATION_BUFFER](#node_creation_buffer) | :white_check_mark: | :white_large_square: |
| [BOLT_PORT](#bolt_port) | :white_check_mark: | :white_large_square: |
| [MAX_QUEUED_QUERIES](#max_queued_queries) | :white_check_mark: | :white_check_mark: |
| [TIMEOUT](#timeout) (deprecated in RedisGraph v2.10) | :white_check_mark: | :white_check_mark: |
| [TIMEOUT_MAX](#timeout_max) (since RedisGraph v2.10) | :white_check_mark: | :white_check_mark: |
| [TIMEOUT_DEFAULT](#timeout_default) (since RedisGraph v2.10) | :white_check_mark: | :white_check_mark: |
| [RESULTSET_SIZE](#resultset_size) | :white_check_mark: | :white_check_mark: |
| [QUERY_MEM_CAPACITY](#query_mem_capacity) | :white_check_mark: | :white_check_mark: |
| [VKEY_MAX_ENTITY_COUNT](#vkey_max_entity_count) | :white_check_mark: | :white_check_mark: |
| [EFFECTS_THRESHOLD](#effects_threshold) | :white_check_mark: | :white_check_mark: |
| Configuration Parameter | Load-time| Run-time|
| :------- | :-----| :-----|
| [THREAD_COUNT](#thread_count) | V | X |
| [CACHE_SIZE](#cache_size) | V | X |
| [OMP_THREAD_COUNT](#omp_thread_count) | V | X |
| [NODE_CREATION_BUFFER](#node_creation_buffer) | V | X |
| [BOLT_PORT](#bolt_port) | V | X |
| [MAX_QUEUED_QUERIES](#max_queued_queries) | V | V |
| [TIMEOUT](#timeout) (deprecated in RedisGraph v2.10) | V | V |
| [TIMEOUT_MAX](#timeout_max) (since RedisGraph v2.10) | V | V |
| [TIMEOUT_DEFAULT](#timeout_default) (since RedisGraph v2.10) | V | V |
| [RESULTSET_SIZE](#resultset_size) | V | V |
| [QUERY_MEM_CAPACITY](#query_mem_capacity) | V | V |
| [VKEY_MAX_ENTITY_COUNT](#vkey_max_entity_count) | V | V |
| [EFFECTS_THRESHOLD](#effects_threshold) | V | V |

---

Comment on lines 65 to 85
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [11-11]

After the expression ‘for example’, a comma is usually used. Consider adding a comma for grammatical correctness.

- For example the following will run the server with global authentication password and 4 threads.
+ For example, the following will run the server with global authentication password and 4 threads.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [47-47]

The verb form seems incorrect. Consider changing "to allowing" to "to allow" for correct grammar.

- FalkorDB exposes the `GRAPH.CONFIG` command to allowing for the setting and retrieval of configuration parameters at run-time.
+ FalkorDB exposes the `GRAPH.CONFIG` command to allow for the setting and retrieval of configuration parameters at run-time.

Expand Down
Loading