Add additional info on topology activation timeout

FairRootGroup · Apr 16, 2024 · f2234d3 · f2234d3
1 parent 0dd0027
commit f2234d3
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/docs/internal/requests.md b/docs/internal/requests.md
@@ -32,3 +32,26 @@
 | Terminate     | mTopology->ChangeState                                                      |
 | Shutdown      | -                                                                           |
 | Status        | -                                                                           |
+
+
+Run
+    topoFilepath()
+        requestTimeout("topoFilepath..execute")
+    submit
+        makeParams
+            execPlugin
+                execute
+        submitDDSAgents
+            requestTimeout("wait_for lock in submitDDSAgents")
+        waitForNumActiveSlots
+            requestTimeout("waitForNumActiveSlots..waitForNumSlots<dds::tools_api::CSession::EAgentState::active>")
+        getAgentInfo
+            requestTimeout("getAgentInfo..syncSendRequest<SAgentInfoRequest>")
+        attemptSubmitRecovery
+            getNumSlots
+                requestTimeout("getNumSlots..syncSendRequest<SAgentCountRequest>")
+    activate
+        activateDDSTopology
+            requestTimeout("wait_for lock in activateDDSTopology")
+        waitForState
+            requestTimeout("WaitForState {expState}")
diff --git a/odc/Controller.cpp b/odc/Controller.cpp
@@ -807,6 +807,20 @@ bool Controller::activateDDSTopology(const CommonParams& common, Session& sessio
             success = false;
             fillAndLogError(common, error, ErrorCode::RequestTimeout, "Timed out waiting for topology activation");
             OLOG(error, common) << error;
+
+            auto agentInfo = getAgentInfo(common, session);
+            OLOG(info, common) << agentInfo.size() << " DDS agents active:";
+            for (const auto& ai : agentInfo) {
+                OLOG(info, common)
+                    << "  Agent ID: " << ai.m_agentID
+                    << "; host: " << ai.m_host
+                    << "; path: " << ai.m_DDSPath
+                    << "; group: " << ai.m_groupName
+                    << "; slots: " << ai.m_nSlots
+                    << " (idle: " << ai.m_nIdleSlots
+                    << ", executing: " << ai.m_nExecutingSlots << ").";
+            }
+
         } else {
             // try {
             //     if (!session.mCollections.empty()) {