Add a large number of convenience functions to Control and cleanup ru… #203
clippy
9 errors, 25 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 9 |
Warning | 25 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 23 in src/asynch/runner.rs
github-actions / clippy
unused import: `AtatIngress`
warning: unused import: `AtatIngress`
--> src/asynch/runner.rs:23:5
|
23 | AtatIngress as _, UrcChannel,
| ^^^^^^^^^^^
Check warning on line 512 in src/asynch/control.rs
github-actions / clippy
unused variable: `psk`
warning: unused variable: `psk`
--> src/asynch/control.rs:512:41
|
512 | WifiAuthentication::Wpa2Psk(psk) => {
| ^^^ help: if this is intentional, prefix it with an underscore: `_psk`
Check warning on line 523 in src/asynch/control.rs
github-actions / clippy
unreachable call
warning: unreachable call
--> src/asynch/control.rs:523:39
|
523 | config_param: WifiStationConfig::WpaPskOrPassphrase(todo!("hex values?!")),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ --------------------- any code following this expression is unreachable
| |
| unreachable call
|
= note: `#[warn(unreachable_code)]` on by default
Check warning on line 440 in src/asynch/control.rs
github-actions / clippy
unused variable: `channel`
warning: unused variable: `channel`
--> src/asynch/control.rs:440:73
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel`
Check warning on line 440 in src/asynch/control.rs
github-actions / clippy
unused variable: `passphrase`
warning: unused variable: `passphrase`
--> src/asynch/control.rs:440:55
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_passphrase`
Check warning on line 440 in src/asynch/control.rs
github-actions / clippy
unused variable: `ssid`
warning: unused variable: `ssid`
--> src/asynch/control.rs:440:43
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_ssid`
Check warning on line 435 in src/asynch/control.rs
github-actions / clippy
unused variable: `channel`
warning: unused variable: `channel`
--> src/asynch/control.rs:435:55
|
435 | pub async fn start_ap_open(&mut self, ssid: &str, channel: u8) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel`
Check warning on line 435 in src/asynch/control.rs
github-actions / clippy
unused variable: `ssid`
warning: unused variable: `ssid`
--> src/asynch/control.rs:435:43
|
435 | pub async fn start_ap_open(&mut self, ssid: &str, channel: u8) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_ssid`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 122 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:122:16
|
122 | B5250000 = 5250000,
| ^^^^^^^ help: consider: `5_250_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 121 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:121:16
|
121 | B3000000 = 3000000,
| ^^^^^^^ help: consider: `3_000_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 120 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:120:15
|
120 | B921600 = 921600,
| ^^^^^^ help: consider: `921_600`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 119 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:119:15
|
119 | B460800 = 460800,
| ^^^^^^ help: consider: `460_800`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 118 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:118:15
|
118 | B250000 = 250000,
| ^^^^^^ help: consider: `250_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 117 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:117:15
|
117 | B230400 = 230400,
| ^^^^^^ help: consider: `230_400`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 116 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:116:15
|
116 | B115200 = 115200,
| ^^^^^^ help: consider: `115_200`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 69 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:69:15
|
69 | B460800 = 460800,
| ^^^^^^ help: consider: `460_800`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 68 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:68:15
|
68 | B230400 = 230400,
| ^^^^^^ help: consider: `230_400`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
Check warning on line 67 in src/command/system/types.rs
github-actions / clippy
long literal lacking separators
warning: long literal lacking separators
--> src/command/system/types.rs:67:15
|
67 | B115200 = 115200,
| ^^^^^^ help: consider: `115_200`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
= note: `-W clippy::unreadable-literal` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unreadable_literal)]`
Check warning on line 27 in src/asynch/runner.rs
github-actions / clippy
unused import: `Duration`
warning: unused import: `Duration`
--> src/asynch/runner.rs:27:20
|
27 | use embassy_time::{Duration, Timer};
| ^^^^^^^^
Check warning on line 22 in src/asynch/runner.rs
github-actions / clippy
unused import: `SimpleClient`
warning: unused import: `SimpleClient`
--> src/asynch/runner.rs:22:31
|
22 | asynch::{AtatClient as _, SimpleClient},
| ^^^^^^^^^^^^
Check warning on line 5 in src/asynch/runner.rs
github-actions / clippy
unused imports: `ChangeMode`, `self`
warning: unused imports: `ChangeMode`, `self`
--> src/asynch/runner.rs:5:21
|
5 | data_mode::{self, ChangeMode},
| ^^^^ ^^^^^^^^^^
Check warning on line 460 in src/asynch/control.rs
github-actions / clippy
redundant else block
warning: redundant else block
--> src/asynch/control.rs:458:20
|
458 | } else {
| ____________________^
459 | | self.leave().await?;
460 | | };
| |_____________^
|
= help: remove the `else` block and move the contents out
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
= note: `-W clippy::redundant-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::redundant_else)]`
Check warning on line 151 in src/asynch/control.rs
github-actions / clippy
redundant field names in struct initialization
warning: redundant field names in struct initialization
--> src/asynch/control.rs:151:13
|
151 | urc_channel: urc_channel,
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urc_channel`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `-W clippy::redundant-field-names` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::redundant_field_names)]`
Check warning on line 20 in src/asynch/control.rs
github-actions / clippy
unused import: `crate::command::ping::Ping`
warning: unused import: `crate::command::ping::Ping`
--> src/asynch/control.rs:20:5
|
20 | use crate::command::ping::Ping;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check failure on line 104 in src/asynch/runner.rs
github-actions / clippy
failed to resolve: use of undeclared type `Digester`
error[E0433]: failed to resolve: use of undeclared type `Digester`
--> src/asynch/runner.rs:104:13
|
104 | Digester::new(),
| ^^^^^^^^ use of undeclared type `Digester`
|
help: consider importing one of these items
|
1 + use atat::Digester;
|
1 + use crate::atat::Digester;
|