Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature): Add simple activate if module already have config #71

Merged
merged 3 commits into from
Dec 4, 2023

Merge branch 'master' into use_stored_wifi_profile

ffb4efe
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

(feature): Add simple activate if module already have config #71

Merge branch 'master' into use_stored_wifi_profile
ffb4efe
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Dec 4, 2023 in 0s

clippy

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.72.0-nightly (5ea666864 2023-06-27)
  • cargo 1.72.0-nightly (03bc66b55 2023-06-23)
  • clippy 0.1.72 (5ea6668 2023-06-27)

Annotations

Check warning on line 201 in ublox-short-range/src/wifi/sta.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> ublox-short-range/src/wifi/sta.rs:201:9
    |
201 |         return Err(WifiConnectionError::Illegal);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
201 -         return Err(WifiConnectionError::Illegal);
201 +         Err(WifiConnectionError::Illegal)
    |

Check warning on line 149 in ublox-short-range/src/wifi/sta.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> ublox-short-range/src/wifi/sta.rs:149:9
    |
149 |         return Ok(());
    |         ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
149 -         return Ok(());
149 +         Ok(())
    |

Check warning on line 108 in ublox-short-range/src/wifi/sta.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> ublox-short-range/src/wifi/sta.rs:108:73
    |
108 |                     config_param: WifiStationConfig::WpaPskOrPassphrase(&pass),
    |                                                                         ^^^^^ help: change this to: `pass`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 62 in ublox-short-range/src/command/edm/urc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> ublox-short-range/src/command/edm/urc.rs:62:77
   |
62 |             defmt::error!("[Parse URC Start/End byte Error] {:?}", LossyStr(&resp));
   |                                                                             ^^^^^ help: change this to: `resp`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 70 in ublox-short-range/src/command/custom_digest.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> ublox-short-range/src/command/custom_digest.rs:70:51
   |
70 |             defmt::trace!("Digest {:?}", LossyStr(&buf));
   |                                                   ^^^^ help: change this to: `buf`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 21 in ublox-short-range/src/command/custom_digest.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> ublox-short-range/src/command/custom_digest.rs:21:47
   |
21 |         defmt::trace!("Digest {:?}", LossyStr(&buf));
   |                                               ^^^^ help: change this to: `buf`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 200 in ublox-short-range/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> ublox-short-range/src/client.rs:200:51
    |
200 |             buffers.split_blocking(tx, EdmDigester::default(), atat::Config::default());
    |                                                   ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

Check warning on line 64 in ublox-short-range/src/wifi/udp_stack.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `peer_handle` is never read

warning: value assigned to `peer_handle` is never read
  --> ublox-short-range/src/wifi/udp_stack.rs:64:17
   |
64 |         let mut peer_handle = crate::command::PeerHandle(0);
   |                 ^^^^^^^^^^^
   |
   = help: maybe it is overwritten before being read?
   = note: `#[warn(unused_assignments)]` on by default

Check warning on line 63 in ublox-short-range/src/command/wifi/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `e`

warning: unused variable: `e`
  --> ublox-short-range/src/command/wifi/mod.rs:63:73
   |
63 |                 atat::serde_at::from_slice::<NoResponse>(resp).map_err(|e| atat::Error::Parse)
   |                                                                         ^ help: if this is intentional, prefix it with an underscore: `_e`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 224 in ublox-short-range/src/wifi/tcp_stack.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded unit expression

warning: unneeded unit expression
   --> ublox-short-range/src/wifi/tcp_stack.rs:224:33
    |
224 | ...                   ()
    |                       ^^ help: remove the final `()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
    = note: `#[warn(clippy::unused_unit)]` on by default