Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework updates #270

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Framework updates #270

wants to merge 6 commits into from

Conversation

its-miroma
Copy link
Member

@its-miroma its-miroma commented Jan 22, 2025

  • Update .github/CODEOWNERS
  • build.yml: run on main only
    • otherwise pull requests from l10n/main run build twice
    • add conditions to avoid "Run failed" mails
  • markdownlint.yml: remove branches
    • paths already excludes pull requests from l10n/main
    • remove workflow_dispatch
  • publish.yml: add conditions to avoid "Run failed" mails
  • settings.gradle: build latest only
  • update.ts: don't add new versions to settings.gradle

@its-miroma its-miroma added needs-discussion Further discussion is needed framework Related to the website's framework (Vitepress) stage:verification This should be verified labels Jan 22, 2025
@its-miroma its-miroma requested review from a team as code owners January 22, 2025 21:17
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit a7affd5
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67969aeda1e81f00083ea970
😎 Deploy Preview https://deploy-preview-270--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@its-miroma its-miroma requested a review from modmuss50 January 22, 2025 21:19
modmuss50
modmuss50 previously approved these changes Jan 22, 2025
@its-miroma its-miroma requested a review from modmuss50 January 22, 2025 21:39
@its-miroma its-miroma added stage:ready This is ready to be merged and removed stage:verification This should be verified labels Jan 22, 2025
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
- Update `.github/CODEOWNERS`
- `build.yml`: run on `main` only
  - otherwise pull requests from `l10n/main` run build twice
- `markdownlint.yml`: remove `branches`
  - `paths` already excludes pull requests from `l10n/main`
- `settings.gradle`: build `latest` only
- `update.ts`: don't add new versions to `settings.gradle`
@its-miroma its-miroma force-pushed the framework branch 6 times, most recently from 16bd9b8 to 72c82cf Compare January 26, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Related to the website's framework (Vitepress) needs-discussion Further discussion is needed stage:ready This is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants