bgpd: Fix up memory leak in processing eoiu marker #18000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory is being leaked when processing the eoiu marker. BGP is creating a dummy dest to contain the data but it was never freed. As well as the eoiu info was not being freed either. Signed-off-by: Donald Sharp <[email protected]>
mjstapp
reviewed
Feb 4, 2025
| @@ -4310,6 +4313,7 @@ static void eoiu_marker_queue_free(struct meta_queue *mq, struct bgp_dest_queue | |||
| XFREE(MTYPE_BGP_EOIU_MARKER_INFO, dest->info); | |||
| STAILQ_REMOVE_HEAD(l, pq); | |||
| STAILQ_NEXT(dest, pq) = NULL; /* complete unlink */ | |||
| XFREE(MTYPE_BGP_NODE, dest); | |||
There was a problem hiding this comment.
is there a similar problem in other_meta_queue_free() - that's not un-ref'ing or freeing the dests either
There was a problem hiding this comment.
there should not be. The eoiu marker is the only one where a fake dest is created that needs to be deleted on the other side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory is being leaked when processing the eoiu marker. BGP is creating a dummy dest to contain the data but it was never freed. As well as the eoiu info was
not being freed either.